Repository navigation
Reconcile upstream aliases and declarations through #2192 - #348
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge upstream through
7c1c9a36(colbymchenry#2192), preserving upstream ancestry. This brings in colbymchenry#2186, colbymchenry#2187, colbymchenry#2188, colbymchenry#2189 and colbymchenry#2192: C++ declarations around macros and conditionals, React Router config helpers, Lua local aliases, CommonJS require calls and namespace re-exports.Port import/export and alias resolution to the fork's native kernel. Returned Lua module tables define public members; lexical shadows, overwritten tables and forwarding cycles remain unresolved. CommonJS uses explicit forwarded exports, and namespace exports retain their member boundary. Router helpers require a literal object and a direct literal/template result. C++ alias and complex-receiver lookup uses declaration scope plus the caller's include closure; ambiguous owners and unsubstituted template parameters remain unresolved.
Validation: native build and clippy, 52 focused regression controls, 6,868 passing suite tests (34 existing skips), eight unchanged golden dumps, five precision gates, and the TypeScript/UI build all pass. Existing test assertions are unchanged. Twelve pinned real-repository comparisons cover Slim, Vite, Javalin, Petclinic, Exposed, fmt, ripgrep, Express, Kong, bulletproof-react, Zod and nlohmann/json. The six unchanged controls retain identical call edges. Bulletproof-react gains eleven source-checked navigation edges; Zod gains 184 call edges. Source audits verify restored serializer, JSON pointer and Lua forward-function calls, and correct the newly exposed receiver targets. Edge-diff totals include qualified-name/provenance changes and are not counts of unique semantic improvements.
Kong indexing was 9.8 seconds in the final observed run versus 5.5 seconds at baseline, after removing repeated declaration scans from an earlier 28.9-second snapshot. These are single-run observations, not a controlled performance benchmark. Re-index affected projects after upgrading.
README checked: upstream merge point, Parsing, resolution and languages (Parser, Files with syntax errors, Name resolution), native extraction/resolution comparisons, routing additions and measured-results rows. Updated the merge point and current capability descriptions, plus matching site pages and framework coverage. Historical measurements remain pinned to their stated revisions; no fresh performance claim was substituted.