Repository navigation
Bound streaming JSONL record buffering and recover from oversized input - #2
Merged
Merged
Conversation
bconnell
marked this pull request as ready for review
November 9, 2026 02:58
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Replace the unbounded per-line
read_lineallocation with a boundedBufRead::fill_bufscanner. Each record is limited to 1,048,576 bytes including its newline. The scanner drains the rest of an oversized record without buffering it and can resume on the next line. Malformed UTF-8 records are counted as malformed in non-strict mode; strict mode emits a safe line-numbered failure. The core parsing, filtering, normalized timestamp comparison, original-byte JSONL output, and exact summary semantics remain otherwise intact.Tests include oversized lines followed by valid JSON, strict oversize rejection without logging input content, malformed UTF-8 recovery, and the exact memory-limit boundary. README discloses the per-record bound and remaining unbounded growth in distinct summary codes.
Gold Standard merge gates
Repository baseline lacks the
Cargo.lockrequired by its validation contract. The temporary PR job first creates a reviewable lockfile artifact, followed by source tests. Before merge, commit that exact verified lockfile, switch workflow to--lockedfor tests and Release build, run text gate, rustfmt, Clippy and CLI on the exact updated head, verify jobs and re-review. Remain draft until complete. No permanent dependency-generation, external telemetry or background service is intended.