Skip to content

Feat/devsu 3043 add ability to set report to nonproduction - #128

Merged
elewis2 merged 9 commits into
developfrom
feat/DEVSU-3043-add-ability-to-set-report-to-nonproduction
Nov 13, 2026
Merged

elewis2 merged 9 commits into
developfrom
feat/DEVSU-3043-add-ability-to-set-report-to-nonproduction

Conversation

@elewis2

@elewis2 elewis2 commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@elewis2
elewis2 requested review from dustinbleile and a balanced review from Copilot November 13, 2026 22:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Omitting state overwrites an existing report state with ready, while an incorrect test lookup leaves synchronous seqQC preservation unchecked.

2 open issues
What changed in this PR

Adds a report-state option to the IPR upload flow so callers can explicitly mark reports as nonproduction.

Changes:

  • Adds --state to the CLI and a corresponding Python API parameter.
  • Adds state-handling tests and updates upload assertions for variant names and seqQC placement.
  • Updates CI coverage to Python 3.11–3.13, with quick tests running on 3.13.
File Description
tests/​test_ipr/​test_upload.py Tests uploaded report states and updates variant and seqQC assertions.
tests/​test_ipr/​test_main.py Adds CLI and Python API tests for report-state handling.
pori_python/​ipr/​main.py Accepts the state option and applies it to report content.
.github/​workflows/​quick-pytest.yml Moves quick tests to Python 3.13.
.github/​workflows/​pytest.yml Updates the test matrix to Python 3.11–3.13.

Review effort: Balanced

Comment thread pori_python/ipr/main.py Resolved
Comment thread tests/test_ipr/test_upload.py Resolved
@codecov-commenter

codecov-commenter commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.02%. Comparing base (79c350c) to head (80430ba).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #128      +/-   ##
===========================================
+ Coverage    87.86%   88.02%   +0.16%     
===========================================
  Files           18       18              
  Lines         2636     2639       +3     
===========================================
+ Hits          2316     2323       +7     
+ Misses         320      316       -4     
Flag Coverage Δ
unittests 88.02% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The upload documentation incorrectly describes state precedence: an explicit state overrides the input JSON’s state, while omitting the argument preserves it.

1 open issue
2 resolved since last review

Review effort: Balanced

Comment thread pori_python/ipr/main.py Resolved
Clarify state parameter behavior in report creation.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@elewis2
elewis2 merged commit 8036ae8 into develop Nov 13, 2026
4 checks passed
@elewis2
elewis2 deleted the feat/DEVSU-3043-add-ability-to-set-report-to-nonproduction branch November 13, 2026 23:56
@elewis2 elewis2 mentioned this pull request Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants