Repository navigation
Feat/devsu 3043 add ability to set report to nonproduction - #128
Merged
elewis2 merged 9 commits intoNov 13, 2026
Merged
Conversation
elewis2
requested review from
dustinbleile
and
a balanced review from Copilot
November 13, 2026 22:28
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Omitting state overwrites an existing report state with ready, while an incorrect test lookup leaves synchronous seqQC preservation unchecked.
2 open issues
What changed in this PR
Adds a report-state option to the IPR upload flow so callers can explicitly mark reports as nonproduction.
Changes:
- Adds
--stateto the CLI and a corresponding Python API parameter. - Adds state-handling tests and updates upload assertions for variant names and seqQC placement.
- Updates CI coverage to Python 3.11–3.13, with quick tests running on 3.13.
| File | Description |
|---|---|
tests/test_ipr/test_upload.py |
Tests uploaded report states and updates variant and seqQC assertions. |
tests/test_ipr/test_main.py |
Adds CLI and Python API tests for report-state handling. |
pori_python/ipr/main.py |
Accepts the state option and applies it to report content. |
.github/workflows/quick-pytest.yml |
Moves quick tests to Python 3.13. |
.github/workflows/pytest.yml |
Updates the test matrix to Python 3.11–3.13. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #128 +/- ##
===========================================
+ Coverage 87.86% 88.02% +0.16%
===========================================
Files 18 18
Lines 2636 2639 +3
===========================================
+ Hits 2316 2323 +7
+ Misses 320 316 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Clarify state parameter behavior in report creation. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
dustinbleile
approved these changes
Nov 13, 2026
elewis2
deleted the
feat/DEVSU-3043-add-ability-to-set-report-to-nonproduction
branch
November 13, 2026 23:56
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.