This repository was archived by the owner on Aug 5, 2021. It is now read-only.
Repository navigation
Fix for Issue #70: stopPython() errors - #71
Merged
Merged
Conversation
… other issues or caused other issues. tbd.
…est. seems tests will each run individually, but if run sequentially by the same testrunner they start to exhibit strange failures.
…Handler fixes debugger issues invoking calls to non-existant toString python method. setting a timeout on the multithreaded test lets other tests execute post deadlock
Member
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe I've fixed the issues starting and stopping the Python interpreter from Java. It involves three parts:
PyGILState_Ensure()beforePy_Finalize()JPy_InitThreadsflag to0JPy_free()I've added a test that starts and stops the interpreter twice using calls to
PyLib.startPython()/PyLib.stopPython().I also tweaked the tests to use the JUnit
@Before/@Afterannotations so each test in the test classes gets a brand new interpreter state.I've been able to test on macOS using CPython 2.7 and 3.5 and both have all tests passing.