Importing HEX file adds characters to end of file #74

Activity

1. microbit-carlos commented on Jan 7, 2019

   

   microbit-carlos

   on Jan 7, 2019

   Collaborator

   More actions

   @microbit-sam Could you look at this one?

   We have this problem with all the 1.1.x editors (but not the beta one? Is beta not using MicroPython v1.0?), having a quick look I think they are missing this line: https://github.com/bbcmicrobit/PythonEditor/pull/57/files#diff-6d9d88a8fbf6c28991df9328acc4142aR158

   PythonEditor/python-main.js

   Line 158 in 70b4d15

   var lines = hex_lines.slice(start_line + 1, -5);
2. microbit-sam commented on Jan 7, 2019

   

   microbit-sam

   on Jan 7, 2019

   Collaborator

   More actions

   Yep, literally just submitted a PR to add that in
   https://github.com/microbit-foundation/python-editor/pull/28
3. microbit-carlos commented on Jan 7, 2019

   

   microbit-carlos

   on Jan 7, 2019

   Collaborator

   More actions

   Great, thanks Sam!
4. microbit-carlos commented on Feb 1, 2019

   

   microbit-carlos

   on Feb 1, 2019

   Collaborator

   More actions

   Fix on #89.
5. microbit-carlos

   closed this as completedon Feb 1, 2019
6. microbit-mark

   added a commit that references this issue on Nov 12, 2019

   Decapitalise Bucket names (bbcmicrobit#74)

   25d28e6