Skip to content

workflows: make on_pr_closed.py executable and add permissions test - #4076

Merged
rickeylev merged 1 commit into
bazel-contrib:mainfrom
rickeylev:fix_pr_closed_permissions
Aug 17, 2026
Merged

rickeylev merged 1 commit into
bazel-contrib:mainfrom
rickeylev:fix_pr_closed_permissions

Conversation

@rickeylev

Copy link
Copy Markdown
Collaborator

GitHub Actions workflow step scripts invoked directly as executables require executable file mode (100755). .github/workflows/on_pr_closed.py was checked in with 100644 permissions, causing step execution errors when run directly.

Mark on_pr_closed.py as executable and introduce an automated regression test in tests/workflows/ that asserts any workflow script with a shebang has executable bit permissions. In addition, update agent rules and review skills to audit script execution permissions.

GitHub Actions workflow step scripts invoked directly as executables
require executable file mode (`100755`).
`.github/workflows/on_pr_closed.py` was checked in with `100644`
permissions, causing step execution errors when run directly.

Mark `on_pr_closed.py` as executable and introduce an automated
regression test in `tests/workflows/` that asserts any workflow script
with a shebang has executable bit permissions. In addition, update
agent rules and review skills to audit script execution permissions.
@rickeylev
rickeylev marked this pull request as ready for review August 17, 2026 23:33
@rickeylev
rickeylev requested a review from aignas as a code owner August 17, 2026 23:33
@rickeylev
rickeylev merged commit 42867b6 into bazel-contrib:main Aug 17, 2026
4 of 5 checks passed
@rickeylev
rickeylev deleted the fix_pr_closed_permissions branch August 18, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant