Skip to content

Make v0.4.0: remove property monitor modules (hidden on Make for review) - #7

Open
ivodraginov-cloud wants to merge 1 commit into
mainfrom
feat/make-hide-monitor-modules
Open

ivodraginov-cloud wants to merge 1 commit into
mainfrom
feat/make-hide-monitor-modules

Conversation

@ivodraginov-cloud

Copy link
Copy Markdown
Contributor

Summary

The app no longer generates the 6 property monitor modules or the components that only they use. The owner approved this.

Removed:

  • Modules: Create Property Monitor (Stream Delivery) (createMonitor), Get Property Monitor (getMonitor), Delete Property Monitor (deleteMonitor), List Property Monitors (listMonitors), Watch Property Monitor Events (Instant) (watchMonitorEvents), Watch Property Monitor Events with Property Record (Instant, Billed) (watchMonitorEventsWithProperty).
  • The monitorEvents webhook. Only the two instant triggers used it.
  • The listMonitors RPC. Only getMonitor and deleteMonitor used rpc://listMonitors.
  • The "Property monitors" group and the two instant triggers in modules/groups.json.
  • The monitor modules, the instant triggers, the "Property monitor events" section and the monitor billing lines in README.md.

scripts/catalog-modules.mjs filters the 4 monitor operations out of the vendored catalog. scripts/catalog.json and scripts/catalog.sha256 are unchanged. The other 23 modules and Make an API Call are byte-for-byte unchanged, and so is the guard that blocks POST, PUT and PATCH to property-subscription. 24 modules remain. package.json is now 0.4.0.

Why

The BatchData sandbox token for the Make review does not have the property-subscription permission, so the reviewers cannot test the monitor modules.

Make side

The app batchdata-r6b83g is public and in review, and Make does not let a public app delete components. On Make the 6 modules are set to private instead of deleted. The monitorEvents webhook and the listMonitors RPC stay on Make, and no module uses them. DEVELOPMENT.md has a "Property monitor modules (hidden on Make)" note with these details.

Testing

  • npm test: 78 tests, 78 pass, 0 fail.
  • node scripts/generate.mjs prints generated 24 modules. After it runs, git status shows no change.
  • makecomapp.json has 24 modules (including makeAnApiCall), no webhook component, and one RPC, listSearchSessions.
  • A new test fails if a monitor module name, monitorEvents or rpc://listMonitors appears in makecomapp.json or in a generated file.

Risk

Medium. The change removes components from a public app's source. It does not change any module that remains.

How to revert

Revert this PR, run node scripts/generate.mjs, deploy to Make, and set the 6 modules to public again on Make.

Required reviewers

One person: the owner who directed the change.

Review

Reviewed SHA: aa49294 | Depth: Standard | Rounds: 1 | Findings: 3
Tier: Medium | Directed by: Ivo Draginov | Second check: escalated: public app component removal; findings answered as intentional
Checks on aa49294: npm test exit 0; node scripts/generate.mjs exit 0

  • makecomapp.json:127 | Important | stale-copy | intentional | Make an API Call description still mentions dedicated monitor modules; owner required makeAnApiCall unchanged byte-for-byte
  • DEVELOPMENT.md:57 | Important | stale-docs | intentional | Decisions section still describes monitor and instant-trigger design; owner scoped DEVELOPMENT.md edits, new note explains the removal
  • makecomapp.json:330 | Important | manifest-drift | intentional | repo stops generating the webhook and RPC that stay on Make; documented in DEVELOPMENT.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants