Repository navigation
Make v0.4.0: remove property monitor modules (hidden on Make for review) - #7
Open
ivodraginov-cloud wants to merge 1 commit into
Open
ivodraginov-cloud wants to merge 1 commit into
ivodraginov-cloud wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app no longer generates the 6 property monitor modules or the components that only they use. The owner approved this.
Removed:
createMonitor), Get Property Monitor (getMonitor), Delete Property Monitor (deleteMonitor), List Property Monitors (listMonitors), Watch Property Monitor Events (Instant) (watchMonitorEvents), Watch Property Monitor Events with Property Record (Instant, Billed) (watchMonitorEventsWithProperty).monitorEventswebhook. Only the two instant triggers used it.listMonitorsRPC. OnlygetMonitoranddeleteMonitorusedrpc://listMonitors.modules/groups.json.scripts/catalog-modules.mjsfilters the 4 monitor operations out of the vendored catalog.scripts/catalog.jsonandscripts/catalog.sha256are unchanged. The other 23 modules and Make an API Call are byte-for-byte unchanged, and so is the guard that blocks POST, PUT and PATCH toproperty-subscription. 24 modules remain.package.jsonis now 0.4.0.Why
The BatchData sandbox token for the Make review does not have the property-subscription permission, so the reviewers cannot test the monitor modules.
Make side
The app
batchdata-r6b83gis public and in review, and Make does not let a public app delete components. On Make the 6 modules are set to private instead of deleted. ThemonitorEventswebhook and thelistMonitorsRPC stay on Make, and no module uses them. DEVELOPMENT.md has a "Property monitor modules (hidden on Make)" note with these details.Testing
npm test: 78 tests, 78 pass, 0 fail.node scripts/generate.mjsprintsgenerated 24 modules. After it runs,git statusshows no change.makecomapp.jsonhas 24 modules (including makeAnApiCall), no webhook component, and one RPC,listSearchSessions.monitorEventsorrpc://listMonitorsappears inmakecomapp.jsonor in a generated file.Risk
Medium. The change removes components from a public app's source. It does not change any module that remains.
How to revert
Revert this PR, run
node scripts/generate.mjs, deploy to Make, and set the 6 modules to public again on Make.Required reviewers
One person: the owner who directed the change.
Review
Reviewed SHA: aa49294 | Depth: Standard | Rounds: 1 | Findings: 3
Tier: Medium | Directed by: Ivo Draginov | Second check: escalated: public app component removal; findings answered as intentional
Checks on aa49294: npm test exit 0; node scripts/generate.mjs exit 0
🤖 Generated with Claude Code