Skip to content

fix(ci): require governance approval for Get Started - #1995

Open
youssefea wants to merge 1 commit into
masterfrom
fix/get-started-governance-approval
Open

youssefea wants to merge 1 commit into
masterfrom
fix/get-started-governance-approval

Conversation

@youssefea

Copy link
Copy Markdown
Contributor

What changed? Why?

Changed the Get Started IA gate from three Writer approvals to one Governance Owner approval. The configured Governance Owners are Eric Brown (@ericbrown99) and Mind Apivessa (@mindapivessa), so either can satisfy the gate, matching the existing Build on Base Solutions behavior.

Updated the IA guidelines to state the one-of-two approval policy explicitly.

Notes to reviewers

This PR changes protected CI configuration, so the existing CI Configuration gate will still require three Writer approvals to merge this policy update. Once merged, future Get Started structural changes will require one approval from Eric or Mind.

How has it been tested?

  • npm test — 85 tests passed
  • Added end-to-end coverage showing a regular Writer cannot satisfy the Get Started gate and Mind's approval can.
  • Preserved coverage that a Governance Owner cannot approve their own PR.

Screenshots

N/A (no user-facing rendered-page changes)

Generated with Toshi

@mintlify

mintlify Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
base 🟢 Ready View Preview Sep 21, 2026, 9:52 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

This branch was successfully deployed

1 active deployment
staging - docs — 4fb5d8ba Deployed Sep 21, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants