Skip to content

fix: redirect /wallet-app/* catch-all to /build-on-base/overview - #1994

Open
forumevi wants to merge 2 commits into
base:masterfrom
forumevi:master
Open

forumevi wants to merge 2 commits into
base:masterfrom
forumevi:master

Conversation

@forumevi

Copy link
Copy Markdown

What changed? Why?

Changed the /wallet-app/:slug* redirect destination in docs/docs.json
from /base-app/:slug* to /build-on-base/overview.

The previous destination forwarded to a path with no catch-all rule,
so any /wallet-app/<unknown> URL landed on a 404. Every other
/wallet-app/* rule already points to /build-on-base/overview, so
this makes the catch-all consistent.

Fixes #1992

Notes to reviewers

One-line change in the redirects array. No other rules touched.

How has it been tested?

Before: https://docs.base.org/wallet-app/example-page → 404
After the change is deployed: should redirect to /build-on-base/overview

Screenshots

N/A (no user-facing changes)

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@forumevi

Copy link
Copy Markdown
Author

The linked issue #1992 documents the 404 repro. Let me know if you'd like
me to add a /base-app/:slug* catch-all as an alternative fix.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken redirect: /wallet-app/:slug* catch-all leads to 404

2 participants