Repository navigation
relay#573: outside-session tests wait for a completed probe - #574
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Owner
Author
|
merge-check: merged. approved, target, contract, evidence, owner, weakening |
Owner
Author
|
Merged into epic/525-session-adoption: approved, target, contract, evidence, owner and weakening PASS; ci and verified NA. |
This was referenced Oct 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #573
Outside-session e2e tests read a failed probe's snapshot under load.
osRig.probe()andprobeFrame()now shareprobeRaw(), which returns only once every machine'slastProbeAtmoved and none isunreachable; after a failed probe it moves the clock again, inside the sameosBound.TestOutsideReportForExitedProcessRemovesRow's hook wait missed for the same cause:osSlowProbe'sprobe()returned a timed-out, unreachable frame, so the test killed the process and reported the hook while the machine was unreachable. Not a relay defect.Fix attempts: 1. Tokens: about 66k dev, 45k review.
Minor review findings (not fixed): the
probe()doc comment does not say an unreachable machine is rejected; the wording inprobeRaw's comment could be tighter.Proof:
-run 'Outside|Adopt|Ended' -parallel 64: 13 failures with this bug's signature ("list held", "ended rows", "want idle", "no row for"). Same run after: 0 with the signature. Other failures there are frame timeouts from starvation and adopt-door 404s, outside this contract.-count=3: ok. Alone: ok.-run 'Outside|Adopt'unloaded: ok.Review: clean, no blocking findings (Sonnet, round 1)
Red on main: n/a: three of the four tests exist only on the epic branch; red on the epic head bb10fff under forced CPU load (13 signature failures), 0 after the fix
Real-app check: n/a: test-only change under e2e/, no product code moved
Journey: n/a: no devboxverify journey or product behaviour changes
🤖 Generated with Claude Code