Repository navigation
Outside sessions: claudeSessionId on ended rows (relay#524) - #535
Merged
barelyworkingcode merged 2 commits intoOct 20, 2026
Merged
barelyworkingcode merged 2 commits into
barelyworkingcode merged 2 commits into
Conversation
…ne fields Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Owner
Author
|
Head eeaaed6: e2e features green (579s), fakerelay green (123s). |
Owner
Author
|
merge-check: merged. approved, target, contract, evidence, owner, weakening |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #524
An ended outside-session row now carries
claudeSessionId, its transcript file stem, on the list, the detail and the/ws/outside-sessionssnapshot. Live rows never carry it. fakerelay serves the world keyoutside_sessions[].claude_session_idon ended rows only and refuses it on a live row or with a bad value. fakerelay's terminalsession.launchline gainstemplate_id,directoryandextra_args(always an array); relay's real line does not change.Part of epic #525. Unblocks barelyworkingcode/eve#593. No route, scope, grant or event changes in relay.
What I'd notice: nothing. Nothing user-visible, so no real-app check; the epic's close child runs the verification task.
Tests
e2e/features/g1_outside_claude_session_id_test.go: AC1 (console and host rows), AC2 (detail and WS), AC3 (live row; a resumed session shows once with no key).fakerelay/prooftest: AC4 (served on list, detail, WS; refused on a live row and on bad values), AC5 (launch-line fields,extra_args: []when absent).Notes
directoryonly with the 201 body'sdirectory, both from the fake. Removing thedirectoryline still fails it.claude_session_idin a fakerelay world reads as absent (omitempty), so it is valid on an ended row.Fix attempts: 0. Tokens: about 300k (subagents and coordinator).
Review: no blocking findings (default model; threat model 3a touched)
Journey: n/a: nothing user-visible; the epic close child runs devboxverify on the epic head
Break-and-restore: removed the
ClaudeSessionID = o.ClaudeIDassignment in replaceEndedLocked; TestOutsideEndedListCarriesClaudeSessionID went red (claudeSessionId = <nil>, want "acme-console-stem"); restored byte for byte🤖 Generated with Claude Code