Signalled waits: workbench and panes (workbench-agents, agent-attention, tab-panes, layout-front-door) #214

Child of barelyworkingcode/relay#252. It inherits #252's approval (the owner said "continue" on 2026-10-06).

Story

As the owner, I want these specs to wait on named signals instead of fixed sleeps, so that their runs stop failing for no reason.

What I'd notice

Nothing.

Acceptance criteria

• No waitForTimeout call remains in the specs below.
• Each former wait names its signal: an event, a ready flag, expect.poll or a web-first assertion.
• Each "nothing happened" check first waits on a positive signal that the triggering work finished.
• Each one-shot locator read followed by an assert becomes a web-first assertion.
• Each spec below passes --repeat-each=5 --retries=0.

Specs

• test/e2e/goals/workbench-agents.spec.js test/e2e/goals/agent-attention.spec.js test/e2e/tab-panes.spec.js test/e2e/layout-front-door.spec.js

Contract

Owned paths: test/e2e/goals/workbench-agents.spec.js, test/e2e/goals/agent-attention.spec.js, test/e2e/tab-panes.spec.js, test/e2e/layout-front-door.spec.js.

Ownership: the four specs above, one per task. test/e2e/socket-watch.js is read-only here. No app code.

• T1 workbench-agents.spec.js. Waits: terminal-joined setup → terminalManager.terminals.has(id); terminal_list handled → waitHandled; log fetch done → AgentBoard.lines.get(id).inflight === false (and all entries not in flight before the :202 negatives). One-shot :167 → toHaveCount(0).
• T2 agent-attention.spec.js. Waits: the ghost session_state and the turn_done frames handled → waitHandled.
• T3 tab-panes.spec.js. Waits: the long-press hold runs on page.clock (time is the input); file_content handled → waitHandled, replacing the in-page setTimeout in framesSentClicking; a closed file tab → web-first. One-shot $$eval at :397 → web-first.
• T4 layout-front-door.spec.js helper expectTodayNoTabs only. Waits: boot restore done → data-ready; restore frames → watchSocketFromLoad sent list (needs test: presets, chat-defaults and voice-buttons wait on named signals (#213) #222). The A5 rejoin test is not touched.
• Break-and-restore, never committed: T1 onTerminalJoined activate=true; T2 turn_done emits idle; T3 drop the close button's mouseup cancel (CRLF file); T4 keep the front-door stamps.

Decisions made for the owner

• T4 waits for test: presets, chat-defaults and voice-buttons wait on named signals (#213) #222 (watchSocketFromLoad) to merge; T1–T3 start first. One PR.
• Not added: a sent-frames check in workbench-agents test 1, and converting the page.evaluate reads in the front-door resume test. Neither is a listed site.
• layout-front-door:74 (eve#137) has no residual wait; confirmed on relay#252.

Tasks

• Planner contract with a Waits: line per task
• Replace the waits and one-shot reads
• Burn-in: --repeat-each=5 on every spec above