Repository navigation
Conversation
JuanLeee
approved these changes
Nov 6, 2026
Every monitored statement ran _cleanup_idle_monitors, which stopped any monitor that wasn't is_usable(), and is_usable() was False whenever the monitor ran on a different loop from the caller's. With one event loop per thread, each loop stopped the other loops' monitors on every statement: monitors and their monitoring connections were recreated continuously, and in-flight statements on the other loop lost failure detection. Key the registry by monitor key and event loop, so each loop reuses its own monitor, and treat a monitor as unusable only when it is stopped, its task has finished, or its loop is closed. Guard the registry with a lock, as sync's monitor service does. Fixes #1287
karenc-bq
force-pushed
the
fix/aio-monitor-loop-keying
branch
from
November 14, 2026 23:45
2f00b58 to
e7300ef
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses issues #1287 and #1276, based on fixes from @AhmadMasry in #1290.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.