Skip to content

fix(aio): async monitor loop - #1348

Open
karenc-bq wants to merge 2 commits into
mainfrom
fix/aio-monitor-loop-keying
Open

karenc-bq wants to merge 2 commits into
mainfrom
fix/aio-monitor-loop-keying

Conversation

@karenc-bq

@karenc-bq karenc-bq commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Addresses issues #1287 and #1276, based on fixes from @AhmadMasry in #1290.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@karenc-bq karenc-bq changed the title fix: async monitor loop fix(aio): async monitor loop Nov 5, 2026
Every monitored statement ran _cleanup_idle_monitors, which stopped any
monitor that wasn't is_usable(), and is_usable() was False whenever the
monitor ran on a different loop from the caller's. With one event loop
per thread, each loop stopped the other loops' monitors on every
statement: monitors and their monitoring connections were recreated
continuously, and in-flight statements on the other loop lost failure
detection.

Key the registry by monitor key and event loop, so each loop reuses its
own monitor, and treat a monitor as unusable only when it is stopped, its
task has finished, or its loop is closed. Guard the registry with a lock,
as sync's monitor service does.

Fixes #1287
@karenc-bq
karenc-bq force-pushed the fix/aio-monitor-loop-keying branch from 2f00b58 to e7300ef Compare November 14, 2026 23:45

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants