Repository navigation
refactor: identify hosts by host id and host-and-port instead of aliases - #1297
Merged
karenc-bq merged 2 commits intoNov 3, 2026
Merged
Conversation
karenc-bq
force-pushed
the
fix/remove-aliases
branch
from
October 20, 2026 08:01
a2afe64 to
06f2e94
Compare
JuanLeee
reviewed
Oct 23, 2026
| raise AwsWrapperError( | ||
| "AsyncPluginService.force_connect requires target_driver_func " | ||
| "to be set; AsyncAwsWrapperConnection.connect normally wires this.") | ||
| self._routed_host_info = None |
Contributor
There was a problem hiding this comment.
Should we also be clearing in force_connect? Wouldn't this clear the routed host mid-connect?
Contributor
Author
There was a problem hiding this comment.
It is cleared in both.
This is called before we connect, ensuring the routed host information from previous connect calls from impacting the current connect.
This was referenced Oct 23, 2026
karenc-bq
force-pushed
the
fix/remove-aliases
branch
from
October 27, 2026 00:19
06f2e94 to
646c562
Compare
karenc-bq
force-pushed
the
fix/remove-aliases
branch
2 times, most recently
from
October 30, 2026 02:23
7c99b62 to
b9fce31
Compare
JuanLeee
reviewed
Oct 30, 2026
| @@ -16,11 +16,11 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Not sure if the deep copy commit is suppose to be included
Contributor
Author
There was a problem hiding this comment.
This one is intentional, it is an integration test fix
JuanLeee
approved these changes
Oct 30, 2026
karenc-bq
force-pushed
the
fix/remove-aliases
branch
from
November 3, 2026 07:03
b9fce31 to
b0720e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.