Skip to content

refactor: identify hosts by host id and host-and-port instead of aliases - #1297

Merged
karenc-bq merged 2 commits into
refactor/aio-storage-and-monitor-servicesfrom
fix/remove-aliases
Nov 3, 2026
Merged

karenc-bq merged 2 commits into
refactor/aio-storage-and-monitor-servicesfrom
fix/remove-aliases

Conversation

@karenc-bq

Copy link
Copy Markdown
Contributor

Description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@karenc-bq
karenc-bq added this pull request to stack #1298 October 20, 2026 07:15
raise AwsWrapperError(
"AsyncPluginService.force_connect requires target_driver_func "
"to be set; AsyncAwsWrapperConnection.connect normally wires this.")
self._routed_host_info = None

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also be clearing in force_connect? Wouldn't this clear the routed host mid-connect?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is cleared in both.
This is called before we connect, ensuring the routed host information from previous connect calls from impacting the current connect.

@@ -16,11 +16,11 @@

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the deep copy commit is suppose to be included

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is intentional, it is an integration test fix

@karenc-bq
karenc-bq merged commit 20d619b into main Nov 3, 2026
9 of 17 checks passed
@karenc-bq
karenc-bq deleted the fix/remove-aliases branch November 3, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants