Repository navigation
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create SSL contexts with
PROTOCOL_TLS_CLIENTinstead of the deprecated no-argumentSSLContext()constructor. Preserve the existing mode-specific hostname policy:verify-cavalidates the certificate chain, an explicitverify-fullenforces the hostname, and the driver-selectedverify-fullkeeps its existing hostname-warning behavior. Certificate validation remainsCERT_REQUIRED.Add three regression cases covering those policies and treating TLS deprecation warnings as errors. Existing hostname-mismatch and untrusted-chain tests are retained.
Motivation and Context
On Python 3.12, every SSL connection with
redshift-connector2.2.0 emits deprecation warnings for the default SSL context andPROTOCOL_TLS. Applications treating deprecation warnings as errors cannot establish a connection.Testing
test/unitsuite, 2089 passed../build.sh: passed.rg.large: 28 IAM-authenticated Datus adapter integration tests passed with this driver patch andDeprecationWarningtreated as an error. The suite exercises SQL, metadata, the shared typed adapter contract, and TPC-H data.git diff --checkpasses.masterreproduces the formatting failures and the same 119 mypy errors in six existing source files; the patch keeps unrelated formatting changes out of this PR.test_write_dataframe_handles_pandas_typesfails identically on unmodifiedmaster; no pandas compatibility changes are included here.Types of changes
Checklist
./build.shsucceedspytest test/unitand they are passing in the environment listed above