You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
py.typed marker file not included in published wheel #257
When I build the package locally, the file is included; however, the layout I get in the locally built wheel is slightly different than the published version, so there is definitely some configuration or setuptools/wheel version difference.
I'm not all that familiar with using setuptools, so I'm not sure if the difference there matters (even though those normalize to the same name)
The setuptools docs include this section on how the different package data configuration options interact
To include some data file into the .whl:
(not exclude-package-data) and ((include-package-data and MANIFEST.in) or package-data)
In other words, the file should not be excluded by exclude-package-data (highest priority), AND should be either:
selected by package-data; or
selected by MANIFEST.in AND use include-package-data = true.
The current setup is trying to add any .crt files as well as the LICENSE, NOTICE, and py.typed files using the package_data option, but I don't see anything except the .crt files included in the published wheel
The MANIFEST.in is
include redshift_connector/files/*
recursive-include files *.crt
Since include_package_data is set to True, it seems that the package_data configuration is not being included (i.e. rule 1 is never true) and the only extra files being added are those from rule 2.
Activity
jamesdow21 commentedon Feb 26, 2025
TL;DR: potential fix is to just change
package_data={"redshift-connector": ...in setup.py topackage_data={"redshift_connector": ...What might be happening is that it is due to the "-" vs "_" in the package name at
https://github.com/aws/amazon-redshift-python-driver/blob/master/setup.py#L97
and
https://github.com/aws/amazon-redshift-python-driver/blob/master/setup.py#L131
I'm not all that familiar with using setuptools, so I'm not sure if the difference there matters (even though those normalize to the same name)
The setuptools docs include this section on how the different package data configuration options interact
The current setup is trying to add any .crt files as well as the LICENSE, NOTICE, and py.typed files using the
package_dataoption, but I don't see anything except the .crt files included in the published wheelThe
MANIFEST.inisSince
include_package_datais set to True, it seems that thepackage_dataconfiguration is not being included (i.e. rule 1 is never true) and the only extra files being added are those from rule 2.