Skip to content

Feature request: Warn users when adding multiple values to dimension before flushing #5638

Closed
#5653
Closed
Feature request: Warn users when adding multiple values to dimension before flushing#5638
#5653
Assignees
anafalcao
Labels
feature-requestfeature requestmetrics

Description

@leandrodamascena
leandrodamascena
opened on Nov 24, 2024

Use case

Original issue in TypeScript: aws-powertools/powertools-lambda-typescript#3350

When a user adds multiple values to a single dimension before flushing metrics, only the last value set on the dimension wins.

Solution/User Experience

It would be nice if the metrics object would do a warnings.warning when multiple distinct values are used on a single dimension before flushing. Current behavior uses the last value added to the dimension.

Alternative solutions



Acknowledgment


Activity
  1. leandrodamascena
    added 
    feature-requestfeature request
     
    triagePending triage from maintainers
     on Nov 24, 2024
  2. github-project-automation
    added this to  Powertools for AWS Lambda (Python)on Nov 24, 2024
  3. github-project-automation
    moved this to Triage in  Powertools for AWS Lambda (Python)on Nov 24, 2024
  4. leandrodamascena commented on Nov 25, 2024 
    @leandrodamascena
    leandrodamascena
    on Nov 25, 2024
    ContributorAuthor
    Assigning to @anafalcao
  5. leandrodamascena
    assigned 
    anafalcao
    on Nov 25, 2024
  6. leandrodamascena
    moved this from Triage to Working on it in  Powertools for AWS Lambda (Python)on Nov 25, 2024
  7. leandrodamascena
    added 
    metrics
     and removed 
    triagePending triage from maintainers
     on Nov 25, 2024
  8. anafalcao
    linked a pull request that will close this issuefeat(metrics): warn when overwriting dimension #5653on Nov 26, 2024
  9. anafalcao
    closed this as completedin #5653on Nov 26, 2024
  10. github-project-automation
    moved this from Working on it to Coming soon in  Powertools for AWS Lambda (Python)on Nov 26, 2024
  11. github-actions commented on Nov 26, 2024 
    @github-actions
    github-actionsBot
    on Nov 26, 2024 – with GitHub Actions
    Contributor
    ⚠️COMMENT VISIBILITY WARNING⚠️
    

    This issue is now closed. Please be mindful that future comments are hard for our team to see.
    

    If you need more assistance, please either tag a team member or open a new issue that references this one.
    

    If you wish to keep having a conversation with other community members under this issue feel free to do so.
  12. github-actions
    added 
    pending-releaseFix or implementation already in dev waiting to be released
     on Nov 26, 2024
  13. github-actions commented on Dec 20, 2024 
    @github-actions
    github-actionsBot
    on Dec 20, 2024 – with GitHub Actions
    Contributor
    This is now released under 3.4.0 version!
  14. github-actions
    removed 
    pending-releaseFix or implementation already in dev waiting to be released
     on Dec 20, 2024
  15. leandrodamascena
    moved this from Coming soon to Shipped in  Powertools for AWS Lambda (Python)on Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Metadata
Assignees
Labels
feature-requestfeature requestmetrics
Type
No type
Projects
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions