Repository navigation
cli: resolve external workflow run references - #32
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesRun reference support
Estimated code review effort: 4 (Complex) | ~45 minutes Mergeability Score: 🔵 Low · up to The PR adds support for resolving external workflow run references, but organization validation may be skipped when slug lookup falls back to an organization ID, which could allow an incorrectly scoped run reference to be accepted. The change is mergeable with explicit owner awareness or follow-up on this validation path. Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant run_view
participant parse_run_reference
participant get_verified_org_slug
participant resolve_run_reference
participant ApiClient
run_view->>parse_run_reference: parse supplied run reference
parse_run_reference-->>run_view: return normalized RunReference
run_view->>get_verified_org_slug: verify URL organization scope
get_verified_org_slug->>ApiClient: request organization membership
ApiClient-->>get_verified_org_slug: return organization slug
run_view->>resolve_run_reference: resolve reference for organization
resolve_run_reference->>ApiClient: request the matching run
ApiClient-->>resolve_run_reference: return and validate run data
resolve_run_reference-->>run_view: return resolved run
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
89163ff to
d0af3f8
Compare
Accept positive GitHub run IDs and exact GitHub Actions URLs. Also accept Avrea console run URLs for the active environment. Use direct or bounded platform filters and validate URL context. Regenerate command documentation.
d0af3f8 to
1875531
Compare
Summary by CodeRabbit
avr run viewaccepts Avrea run IDs, GitHub run IDs, GitHub Actions URLs, and Avrea console URLs.RUNargument and examples.