Repository navigation
Fix review process with new ontology - #336
Merged
Merged
Conversation
leefaus
force-pushed
the
fix/triage-review
branch
from
November 15, 2026 16:33
7733812 to
2eab9c6
Compare
The subject scope-completeness rule only recognized includesIntent, but the resolver pins icebox intents under includesSetAside. A change whose retained receipts observe an intent that was later set aside could never pass validation, even when the review intent explicitly reviews it. Accept either relation for scope completeness. Managed-change coverage still requires includesIntent, so a set-aside intent cannot stand in as implementation evidence (covered by the existing retired_intent_cannot_supply_managed_change_coverage test). Note: the shapes file participates in profile_hash, so previously signed reviews will read as stale and need a superseding signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for retrospective publication reviews in the Atomic CLI and related libraries. It adds a new
publication_reviewmodule to the codebase, updates the intent graph command to accept and process review files for diagnostic context, and improves the rendering and annotation of reviewed changes. The changes also enhance the triage output to better distinguish set-aside (historical) intent dispositions and add new color mappings for review-related classes in the query module.Support for publication reviews and review context:
publication_reviewmodule (atomic-canonical/src/publication_review.rs) defining the schema, parsing, and validation logic for publication reviews, including types such asIntentPin,ChangePin,ReviewSubject, andPublicationReview. This enables the system to handle present-day reviews of retained evidence. [1] [2]atomic-cli/src/commands/intent/graph.rs) to accept a--review-fileargument, allowing users to include an unsigned/signed prepared review as diagnostic context. The review is resolved by the repository service but does not imply approval. [1] [2]atomic-cli/src/commands/rpc.rs) to pass the review document to the repository service, validate the review preview identity, and ensure the review is connected to the selected intent. [1] [2] [3]User interface and output improvements:
icebox(set-aside) status, including historical criteria and reviewer attribution. [1] [2]CLI and testing enhancements:
PublicationReviewsubcommand to the triage CLI for preparing, signing, recording, or inspecting retrospective reviews. [1] [2]--review-fileoption.Visual and configuration updates:
review-shaclfeature for theatomic-repositorydependency in the CLI.Documentation and terminology clarifications:
iceboxintent status in documentation, emphasizing that it represents a terminal, set-aside disposition with historical evidence, not a current delivery requirement.