Skip to content

Fix upgrade guidance for versioned installer runtimes - #325

Merged
geekgonecrazy merged 1 commit into
devfrom
fix/versioned-installer-upgrade-guidance
Nov 11, 2026
Merged

geekgonecrazy merged 1 commit into
devfrom
fix/versioned-installer-upgrade-guidance

Conversation

@graywolf336

Copy link
Copy Markdown
Contributor

Problem

The complete-runtime installer exposes Atomic through a command symlink into an immutable release directory. Canonicalizing the installation record before storing its command path makes atomic update recommend installing into that immutable release instead of the original command directory.

Change

  • Continue canonicalizing the recorded path for executable identity verification.
  • Preserve the original install_path for upgrade instructions, including command directories containing spaces.
  • Reject an installation record after its command symlink is retargeted to another executable.
  • Document the complete-runtime installation record and safe upgrade behavior.

Companion to https://github.com/atomicdotdev/atomic-storage/pull/112; stacked on #322.

Verification

  • cargo test -p atomic-cli --bin atomic commands::update::tests: 36 passed.
  • Built the actual CLI and installed it with the fixed storage installer alongside a real native runtime, into a command directory containing spaces.
  • Invoked the installed command symlink with isolated configuration: diagnostics reported install_source=installer; atomic update exited successfully and reported the current release.
  • The regression covers upgrade command destination, shell quoting, and symlink retarget rejection.

No production or staging server deployment performed.

@graywolf336
graywolf336 added this pull request to stack #326 November 10, 2026 21:08
Base automatically changed from feat/native-nodeatomic-cutover to dev November 11, 2026 18:37
@geekgonecrazy
geekgonecrazy force-pushed the fix/versioned-installer-upgrade-guidance branch from 0709863 to 2885194 Compare November 11, 2026 18:38
@geekgonecrazy
geekgonecrazy merged commit 6f8d276 into dev Nov 11, 2026
2 checks passed
@geekgonecrazy
geekgonecrazy deleted the fix/versioned-installer-upgrade-guidance branch November 11, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants