Skip to content

feat(intent): replay bounded retained evidence with native freshness pins - #234

Merged
graywolf336 merged 7 commits into
atomicdotdev:devfrom
astrogilda:feat/criterion-evidence-replay
Nov 3, 2026
Merged

graywolf336 merged 7 commits into
atomicdotdev:devfrom
astrogilda:feat/criterion-evidence-replay

Conversation

@astrogilda

Copy link
Copy Markdown
Contributor

Atomic's authoring gate checks declared verification records, but the CLI has no optional route for reviewers to replay narrowly defined claims from retained evidence. This adds intent validate --replay-evidence MANIFEST --evidence-checker PROGRAM, plus --json --evidence-context for native pins. Ordinary validation remains unchanged, and replay never marks an acceptance criterion met.

The manifest binds the native criterion, intent substance and full stored source, selected view and ancestor Merkle/scope chain, case, and consumer policy. Atomic explicitly invokes a locally selected checker without a shell, enforces time and input/output limits, admits JSON through its existing byte boundary, and rejects unbound responses. Pins are checked again after invocation. Supported, contradicted, and not-established results retain their scope; missing, unsupported, stale, malformed, failed, and timed-out evidence cannot pass.

An optional Python recipe uses Probity Verify's four existing bounded adapters. For example, retaining selected passages supports a source-coverage claim; changed bytes against the original digest are unknown, while a repinned record omitting a selected passage is contradicted. These claims do not establish arbitrary task correctness or authenticate a witness. Python is optional and the core dependency is unchanged.

Validation: native signed-intent CLI integration, six replay controls, five installed-checker semantic controls, retained native CLI source-coverage controls, existing vault-context/view-switch tests, and strict CLI/repository Clippy checks passed. The preceding isolated commit repairs two existing Clippy findings without changing helper behavior. The committed full CLI suite passed 2038 tests, with results retained in the delivery receipt.

@graywolf336
graywolf336 force-pushed the feat/criterion-evidence-replay branch from 814c9aa to 773b917 Compare October 23, 2026 16:22
Move the bounded replay protocol into atomic-repository so the CLI and the
daemon bind the same native pins and manifest rules. Add ReplayVaultEvidence
to VaultService for context-only and replay requests; the handler gates the
intent, releases the repository gate before the checker runs, and re-reads the
pins afterward.

The CLI sends the manifest bytes, an absolute artifact base, and the explicit
checker path, then renders the same JSON shape as the local body. Plain
ValidateVaultEntity stays unchanged. Evidence replay remains local-caller only
and never changes acceptance status.
@graywolf336

Copy link
Copy Markdown
Contributor

@astrogilda thank you for submitting this! I've rebased it upon the latest dev version and even took it a step further and integrated it into our triage review command (#282) and skills (atomicdotdev/atomic-skills#5) so that it makes it easier and more integrated into the full system. Let me know if you have any thoughts or suggestions on these additions.

@astrogilda

Copy link
Copy Markdown
Contributor Author

@graywolf336 thanks for taking it into triage, #282 and the skill read right to me. One gap: the triage summary drops the checker's details, so a reviewer can't check the allowlist the skill asks for.

I opened #284 on top of #282 to carry the checker release into each decision and pin probity-verify with hashes, a CI job and Dependabot. atomicdotdev/atomic-skills#6 adds the matching skill line.

@graywolf336
graywolf336 merged commit d34e330 into atomicdotdev:dev Nov 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants