[ulidtko]

Hi @lee-dohm, please review

Before:

After:

[lee-dohm]

Please edit the body to include the template and fill in the relevant details. One detail to include is why you only allow space characters instead of whitespace in general?

[ulidtko]

Well, primarily because HT, VT, FF, NBSP and all those other whitespace goodies Unicode has to offer are... very weird characters to use middle-line in a shell script. Even the Holy Tab (HT, U+0009) is a dubious choice to delimit a heredoc token.

I actually started with \s* at first, but that didn't work for some reason, — and as an afterthought, I figured that the breaking of syntax highlighting is in a sense useful as a pretty good signal that you'd better use a plain U+0020 space here. After all, this is a shell script. Bonus point: the <<- form of heredoc makes harsh distinction between tabs and spaces, so one would better be reminded of that.

Sorry about the template, it's pretty boring to fill out. This is a simple, mostly aesthetic change.

[lee-dohm]

I understand that the template is boring to fill out, but a little bit of work ahead of time means less back and forth for maintainers. This means that we can respond more quickly to everyone's pull requests.

…

On Dec 26, 2016, at 1:38 PM, Maxim Ivanov ***@***.***> wrote: Well, primarily because HT, VT, FF, NBSP and all those other whitespace goodies Unicode has to offer are... very weird characters to use middle-line in a shell script. Even the Holy Tab (HT, U+0009) is a dubious choice to delimit a heredoc token. I actually started with \s* at first, but that didn't work for some reason, — and as an afterthought, I figured that the breaking of syntax highlighting is in a sense useful as a pretty good signal that you'd better use a plain U+0020 space here. After all, this is a shell script. Bonus point: the <<- form of heredoc makes harsh distinction between tabs and spaces, so one would better be reminded of that. Sorry about the template, it's pretty boring to fill out. This is a simple, mostly aesthetic change. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[winstliu]

Superseded by #77. I tested and hard tabs do in fact work. Thanks for the contributions though @ulidtko!