This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Wrong Syntax Highlighting on mid line # #150
Description
From @IceWreck in microsoft/vscode#78034
Steps to Reproduce:
- Open a bash script. (.sh file)
- Write some code and then type
#in the same line. Example :
sudo dnf remove -y \
krdc \
kmail \
kgpg \
krusader \ # the old kde twinstyle file manager
kruler
- Everything after
#is greyed out and vscode thinks that its a comment, misleading the user
This is wrong, as bash does not consider everything after # as a comment and running the script can lead to disastrous results as it would remove the file package, which is somehow a dependency for essential packages and removing it can break the system.
Activity
rsese commentedon Jul 30, 2019
Thanks for the report 👍 I can reproduce on macOS 10.14 with 1.41.0-nightly3 using Tree-sitter. Please note however that we would only resolve the issue in the Tree-sitter grammar since we're generally no longer maintaining the first-mate grammar when there is a built-in Tree-sitter grammar available.
lkashef commentedon Dec 2, 2019
Hello @alexr00, thank you for the report.
I am actually trying to reproduce this in atom 1.41.0 stable without success, could you confirm on your end if the issue still persist.
alexr00 commentedon Dec 2, 2019
@lkashef your screen shot is showing the same problem. The characters after the # are tokenized as a comment, when they should not be.
lkashef commentedon Dec 2, 2019
@alexr00 the inline comment is not allowed, I got what you mean. Thanks.
lkashef commentedon Dec 3, 2019
This issue seems to be originating from tree-sitter-bash, so I created an issue that will hopefully fix this issue and microsoft/vscode#78034.