This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
Async indent - #214
Merged
Merged
Async indent#214
Conversation
winstliu
reviewed
Oct 18, 2017
| beforeEach -> | ||
| waitsForPromise -> | ||
| atom.workspace.open('sample.py').then (o) -> | ||
| atom.workspace.open('../../sample.py').then (o) -> |
Contributor
There was a problem hiding this comment.
This can actually just be atom.workspace.open(). No need to specify a filename.
| 'tabLength': 4 | ||
| 'commentStart': '# ' | ||
| 'increaseIndentPattern': '^\\s*(class|def|elif|else|except|finally|for|if|try|with|while)\\b.*:\\s*$' | ||
| 'increaseIndentPattern': '^\\s*(class|def|elif|else|except|finally|for|if|try|with|while|async def|async for|async with)\\b.*:\\s*$' |
Contributor
There was a problem hiding this comment.
What about async\\s+(def|for|with)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Add async syntax to indentation regex
Alternate Designs
None.
Benefits
Python 3.5 introduced async syntax, this will allow proper indentation when using said syntax.
Possible Drawbacks
None.............................?
Applicable Issues
Not an issue, but this PR #152 has been open for > 1 year.