[kbrose]

Description of the Change

• Add spec file for indentations. Modeled after https://github.com/atom/language-go/blob/master/spec/language-go-spec.coffee
• Dedent next line after some expressions (pass|return|yield|continue|break|raise)

Alternate Designs

None.

Benefits

Better support for the Python language.

Possible Drawbacks

• yet another regex to run text on
• do you ever not want to dedent on one of return|yield|continue|break|raise?
• might break 3rd party python indentation packages, e.g. https://github.com/DSpeckhals/python-indent

Applicable Issues

• [FEATURE] De-dent after appropriate statements DSpeckhals/python-indent#20
• Move Line breaks indentation in python atom#12742

[winstliu]

🔥 empty line

[kbrose]

removed

[winstliu]

Nice! Regexes look good and 💯 on that spec file.

[kbrose]

Thanks for reviewing @50Wliu. Let me know what else I can do.

[Sherlock-Holo]

It is a very bad feature for me!!!! There must be some people like me want to turn off this feature. How do I do to turn off this feature?

[Sherlock-Holo]

when I try to write:

def main():
    if True:
        return 1
    else:
        return 2

the else will dedent, it is a bad behaviour.

[kbrose]

Sorry to hear it doesn't work for you, but I think calling it "a very bad feature" is a bit of a stretch. I've been using it for the past few months and while it is by no means perfect, it has definitely had a net positive effect on the amount of typing I have to do to get correct indentations in Atom. (I could just as easily construct an example that did not correctly dedent before, but now does correctly dedent, and say that the old behavior was "a bad behavior". Trying to parse a complete language with regexes will always have trade-offs.)

Still, if it doesn't work for you then it should be fairly straightforward to submit a PR which makes it an option in language-python. In the meantime, you could comment out the line

'decreaseNextIndentPattern': '^\\s*(pass|return|yield|continue|break|raise)\\b.*$'

from the effected file then you should stop seeing the behavior.

[Sherlock-Holo]

@kbrose Thanks for your advice, unfortunately I can't find which file I should modify. Could you tell me more about it?

[Hanzhizheng]

def f(n,lookup):
    if n==0 or n==1:
        lookup[n]=n
    if lookup[n] is None:
        lookup[n]=f(n-1,lookup=)+f(n-2,lookup=)
    return lookup[n]

the auto '=' in params

def x(n):
    if n==1:
        return n

when coding n you type 'tab' it comes out the list tochoice like this: v n, the tab doesn't work.

def x(n):
    if n==1:
        return n
else:

type ':' the else will auto move to the head.

[Sherlock-Holo]

I found it too and I don't think it is a very good feature

…

On 2017年10月9日周一 19:53 zDoNZaI ***@***.***> wrote: def f(n,lookup): if n==0 or n==1: lookup[n]=n if lookup[n] is None: lookup[n]=f(n-1,lookup=)+f(n-2,lookup=) return lookup[n] the auto '=' in params def x(n): if n==1: return n when coding n you type 'tab' it comes out the list tochoice like this: v n, the tab doesn't work. def x(n): if n==1: return n else: type ':' the else will auto move to the head. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#204 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJoPKQHn1DlQulne1HJeMSaDRCyya2wZks5sqgkfgaJpZM4OQer_> .