SQL syntax coloring in string literals broken for versions greater than 0.51.9 #306

Activity

1. rsese commented on Jun 5, 2019

   

   rsese

   on Jun 5, 2019

   More actions

   Thanks for the report! Can you share the code itself so we can copy/paste to try it out?
2. rsese

   added

   more-information-needed

   on Jun 5, 2019
3. fgiamma commented on Jun 5, 2019

   

   fgiamma

   on Jun 5, 2019

   Author

   More actions

   Hello, I will attach the code below, but any sql string will do.

   #!/usr/bin/env python3
   from initclass import InitClass
   import sys
   import os
   sys.path.append(os.path.abspath("../../"))
   
   
   class Test(InitClass):
       def __init__(self):
           super().__init__()
   
       def process(self):
           # This is my comment
           sql = "SELECT documents.* FROM documents"
           documents = self.db.fetch_all(sql, [])
           for document in documents:
               print(document["name"])
   
   
   t = Test()
   t.process()
   

   Fabrizio
4. no-response

   removed

   more-information-needed

   on Jun 5, 2019
5. Arcanemagus commented on Jun 5, 2019

   

   Arcanemagus

   on Jun 5, 2019

   More actions

   This is due to language-sql currently not having a Tree-sitter based implementation, meaning that language-python can't bring it in to syntax highlight the strings. You can check out atom/language-ruby#249 (comment) for a detailed explanation about this issue with regards to language-ruby, the core problem is the same though.

   For now if you need that functionality you can switch to the old TextMate grammar by unchecking "Use Tree-sitter parsers" option:
   

   Note however that the highlighting of your Python code (and other languages) will suffer from doing that, as TextMate grammars have many other issues with parsing that the Tree-sitter system allows us to solve easily.
6. fgiamma commented on Jun 5, 2019

   

   fgiamma

   on Jun 5, 2019

   Author

   More actions

   Thanks @Arcanemagus, I wasn't aware of this issue, I still can't understand why for versions of atom under 1.37.0 the syntax highlight still works. My current atom setup is a downgraded 1.36.1 and even though "Use tree sitter parsers" is checked, it works like a charm and correctly highlights sql in strings, if I upgrade to 1.37.0 or newer it doesn't work anymore...
7. contang0 commented on Feb 23, 2020

   

   contang0

   on Feb 23, 2020

   More actions

   For me downgrading to 1.36 doesn't help. Any chance this issue will be solved?

   👍React with 👍1Reacted by MA