Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

PEP 515: Underscores in numeric literals #221

Open

Description

@redfast00

Prerequisites

Description

Numbers like 100_000_000 aren't properly highlighted (see PEP 515 specification). This should be pretty easy to fix, just edit these lines in the grammar. I tried to fix this myself, but wasn't able to get atom dev running.

Steps to Reproduce

  1. Put 10_000_000 in source code.

Expected behavior:
Proper highlighting

Actual behavior:
Number highlighting stops in the middle of the number

Reproduces how often:
100%

Versions

Atom    : 1.23.3
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0

Activity

  1. winstliu commented on Jan 21, 2018

    @winstliu
    Contributor

    I tried to fix this myself, but wasn't able to get atom dev running.

    Please ping me in the Slack channel or on Discuss and I'll help you out. I'm @Wliu on both.

  2. Alexey-T commented on Oct 1, 2019

    @Alexey-T

    Why isn’t it fixed yet? Easy to do

  3. kac487 commented on Sep 7, 2021

    @kac487

    Are there any updates on this one?

  4. self-assigned this
    on Sep 14, 2021
  5. winstliu commented on Sep 14, 2021

    @winstliu
    Contributor

    @kac487 do you know if this is happening with the Tree Sitter grammar, or just the non-Tree Sitter one? (If you don't know, that's fine)

  6. kac487 commented on Sep 18, 2021

    @kac487

    Sorry, I don't know which one it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions