Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add support for optional chaining within template literals - #586

Closed
brennenberkley wants to merge 2 commits into
atom:masterfrom
brennenberkley:optional-chaining
Closed

brennenberkley wants to merge 2 commits into
atom:masterfrom
brennenberkley:optional-chaining

Conversation

@brennenberkley

Copy link
Copy Markdown

Description of the Change

  • Change the pattern for matching objects to include support for optional changing, i.e. obj?.prop
  • Change the pattern for matching the ternary operator to fail if followed by a period

Alternate Designs

None

Benefits

Using conditional chaining will not break syntax highlighting as shown in #584

Possible Drawbacks

I did not add any specific category for ?, but that could be handled in another PR

Applicable Issues

#584

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant