This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Missing variable syntax scopes #630
Description
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
Missing extra variable syntax wrappers when using tree-sitter
Settings > Core > Use Tree Sitter Parsers - Enabled
Settings > Core > Use Tree Sitter Parsers - Disabled
Versions
Atom : 1.32.2
Electron: 2.0.9
Chrome : 61.0.3163.100
Node : 8.9.3
Additional Information
Both examples above are without language-babel and without customFileTypes in config.cson
Workaround with tree sitter parsers enabled is to have language-babel and this in my config.cson:
customFileTypes:
"source.js.jsx": [
"js"
"jsx"
]
The downside to the workaround is all my .js files show up as .jsx files when using file-icons
Activity
rsese commentedon Nov 29, 2018
Thanks for the report! Looks like this is fixed in 1.34 which is currently in beta:
Going to go ahead and close but let me know if I misunderstood anything.
pbarbiero commentedon Jan 9, 2019
Hi @rsese
I am testing with 1.34 and I still see some problems. I am trying to update my syntax to utilize the different scopes (and lack of nested scopes now too) and I cant figure out how to solve some situations -- are these changes by design or maybe an oversight?
Line 1: No problems
Line 2: No scope present for
param3Line 3: No scope present for
param1andparam2Line 4: Same as line 3 except also no scope present for
resultLine 5: No scope present for
paramandstoreExample of what happens when I disable tree-sitter:
Notes:
line 4 lets me differentiate
resultfromresultin line 3line 5 lets me differentiate
storefromparam1rsese commentedon Jan 17, 2019
Thanks @pbarbiero - since the initial example originally reported looks ok would you mind opening a new issue with template filled out and with the details from #630 (comment)?