Tree-sitter missing variable.language scope #618

Activity

1. Ben3eeE

   added

   regression

   tree-sitter

   triaged

   on Nov 1, 2018
2. lee-dohm commented on Nov 13, 2018

   

   lee-dohm

   on Nov 13, 2018

   Contributor

   More actions

   @maxbrunsfeld can you give some more information here?
3. maxbrunsfeld commented on Nov 13, 2018

   

   maxbrunsfeld

   on Nov 13, 2018

   Contributor

   More actions

   Ok, #620 added back the scope for arguments and super. The default keyword is intentionally highlighted as keyword.control.

   I'll leave this issue open because of the this variable. We're intentionally not highlighting this as language.variable because it causes this to be highlighted the same as object properties in most themes, and that was something we wanted to fix when updating from TextMate to Tree-sitter.

   We have a PR open to figure out a different color for these kinds of special variables. When we finish that, we'll circle back here and update this to use that class.
4. caleb531 commented on Mar 31, 2019

   

   caleb531

   on Mar 31, 2019

   Last edited by caleb531

   Contributor

   More actions

   @chbk You might be pleased to know: I developed a hackish solution to inject highlighting for this and super into the built-in language-javascript grammar. This absolves you of any need to fork the language-javascript package, compile tree-sitter grammars, or rebuild Atom. Just place the following code in your init.coffee:

   # Extend the JavaScript tree-sitter grammar with additional highlighting
   extendJavaScriptTSGrammar = ->
     # All Atom grammars are loaded asynchronously, so use setImmediate() to
     # ensure that the JS grammar is only modified when it has fully loaded
     setImmediate ->
       jsGrammar = atom.grammars.treeSitterGrammarsById['source.js']
       if jsGrammar
         # Colorize `this`, `super`, and `arguments` in red (like other language keywords)
         jsGrammar.scopeMap.addSelector('this', 'variable.language.js')
         jsGrammar.scopeMap.addSelector('super', 'variable.language.js')
         jsGrammar.scopeMap.addSelector('super', 'variable.language.js')
         jsGrammar.scopeMap.addSelector('identifier', {
           match: /^arguments$/,
           scopes: 'variable.language.js'
         });
   extendJavaScriptTSGrammar()