Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

module name and comments not highlighted in module-info.java #245

Open

Description

@Eskibear

Description

Also reported in redhat-developer/vscode-java#1384
JEP reference about module system: https://openjdk.java.net/jeps/261

image

Expected behavior:

  • com.foo.bar and java.base should be highlighted.
  • comments in Line 4 should be hightlighted.

Versions

it's tested on vscode@1.53.0-insiders, should be latest release of atom/language-java

Activity

  1. Eskibear commented on Jan 20, 2021

    @Eskibear
    ContributorAuthor

    @sadikovi Can you take a look please? FYI that we might be able to work "module names" around via semantic highlighting. So comments part should have a higher priority if you are short of bandwidth...

  2. Eskibear commented on Jan 20, 2021

    @Eskibear
    ContributorAuthor

    I just created a PR against the comments part. please take a look.

  3. added a commit that references this issue on Jan 23, 2021
  4. sadikovi commented on Jan 23, 2021

    @sadikovi
    Contributor

    Shall we close this issue or is there anything else left to do?

  5. Eskibear commented on Jan 25, 2021

    @Eskibear
    ContributorAuthor

    com.foo.bar and java.base should be highlighted.

    It would be better if qualified module names can be highlighted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions