Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Scope variables in expressions #221

Open

Description

@JacksonKearl

Summary

It would be helpful to add a scope to the textmate grammar denoting variable read/write access. For example in typescript, the scope variable.other.readwrite is applied.

Motivation

Currently the only scope given to variable read/write access is source.java, which means users and themes cannot configure the appearance of these accesses in themes.

Additional context

Screen Shot 2020-01-19 at 4 12 55 PM

https://www.reddit.com/r/vscode/comments/equyio/im_using_the_horizon_theme_in_vscode_why_do_local/

Activity

  1. changed the title [-]Scope for variable read/write access.[/-] [+]Scope variables in expressions[/+] on Jan 21, 2020
  2. sadikovi commented on Jan 21, 2020

    @sadikovi
    Contributor

    No, we don't do that currently. Can you give examples when it is useful?

  3. JacksonKearl commented on Jan 21, 2020

    @JacksonKearl
    Author

    Currently the only scope given to variable read/write access is source.java, which means users and themes cannot configure the appearance of variable uses in themes.

    Many themes attempt to control variable colors, and they should be able to work in Java in addition to other languages.

  4. sadikovi commented on Jan 22, 2020

    @sadikovi
    Contributor

    Okay, makes sense. I am a bit snowed under at the moment due to bunch of other open-source work, would appreciate a pull request :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions