Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Start-up behavior - #875

Merged
smashwilson merged 12 commits into
masterfrom
aw-first-impressions
May 30, 2017
Merged

smashwilson merged 12 commits into
masterfrom
aw-first-impressions

Conversation

@smashwilson

@smashwilson smashwilson commented May 25, 2017 •

Copy link
Copy Markdown
Contributor

This implements the proposed startup behavior described in #872.

  • If this is the first Atom launch with the github package installed, but the Welcome pane will be shown, start closed. "Version control with Git and GitHub" section welcome#62 will make it redundant in any case.
  • If this is the first Atom launch and the Welcome pane is not shown, start open.
  • If this is not the first Atom launch, start closed.

Uses an (empty except for a comment, right now) flag file called ~/.atom/github.cson to detect prior runs.

@smashwilson smashwilson self-assigned this May 25, 2017

@kuychaco kuychaco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

So the hidden firstRun config option won't actually be hidden for now right? I don't see any PR in atom/atom to account for this new field.

Comment thread package.json Outdated
"type": "boolean",
"default": true,
"description": "Display the Git and GitHub tabs on Atom launch. Reverts to false on each launch.",
"hidden": true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I forgot to 🔥 this.

@smashwilson

Copy link
Copy Markdown
Contributor Author

So the hidden firstRun config option won't actually be hidden for now right? I don't see any PR in atom/atom to account for this new field.

Oops, that config option shouldn't be there. I replaced the functionality with the ~/.atom/github.cson flag file, but I neglected to ✂️ the option.

@smashwilson
smashwilson merged commit dce8a1c into master May 30, 2017
@smashwilson
smashwilson deleted the aw-first-impressions branch May 30, 2017 15:18
This was referenced May 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants