This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
Don't display large diffs by default - #799
Merged
Merged
Conversation
Contributor
Author
|
|
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large diffs can slow down rendering and make Atom feel slow. This is a stopgap solution that presents a GitHub.com-style warning about large diffs that the user can confirm to see the diff; I've set the default threshold to 1000 lines.
Once a user confirms a large diff, its path gets added to a Set that ensures any diff with the same path will always be shown. I debated on this functionality but in the end decided it would make the most sense. 💭 s?
Fixes #786