Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/models/workdir-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export default class WorkdirContext {

/*
* Available options:
* - `options.savedResolutionProgress`: Serialized state used to initialize the ResolutionProgress.
* - `options.window`: Browser window global, used on Linux by the WorkspaceChangeObserver.
* - `options.workspace`: Atom's workspace singleton, used on Linux by the WorkspaceChangeObserver.
* - `options.promptCallback`: Callback used to collect information interactively through Atom.
Expand Down
6 changes: 3 additions & 3 deletions lib/models/workspace-change-observer.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default class WorkspaceChangeObserver {
const focusHandler = event => {
if (this.repository) {
this.logger.showEvents([event]);
this.emitter.emit('did-change');
this.didChange();
}
};
this.window.addEventListener('focus', focusHandler);
Expand Down Expand Up @@ -80,11 +80,11 @@ export default class WorkspaceChangeObserver {
});
if (filteredEvents.length) {
this.logger.showEvents(filteredEvents);
this.emitter.emit('did-change');
this.didChange(filteredEvents);
const workdirOrHeadEvent = filteredEvents.filter(e => !['config', 'index'].includes(e.file || e.newFile));
if (workdirOrHeadEvent) {
this.logger.showWorkdirOrHeadEvents();
this.emitter.emit('did-change-workdir-or-head');
this.didChangeWorkdirOrHead();
}
}
},
Expand Down
3 changes: 2 additions & 1 deletion test/models/workdir-context-pool.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import temp from 'temp';
import {Disposable} from 'event-kit';

import {cloneRepository} from '../helpers';

Expand All @@ -15,7 +16,7 @@ describe('WorkdirContextPool', function() {
};

mockWorkspace = {
observeTextEditors: sinon.spy(),
observeTextEditors: sinon.stub().returns(new Disposable()),
};

pool = new WorkdirContextPool({
Expand Down