This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Repository navigation

Rework GithubPackage model and promise management - #633

Merged

smashwilson merged 172 commits into

masterfrom

aw-single-project-regression

Apr 20, 2017

Merged

Rework GithubPackage model and promise management#633
smashwilson merged 172 commits into
masterfrom
aw-single-project-regression

Commits on Mar 30, 2017
- (Hopefully) cleaner model and Promise management in GithubPackage
  smashwilson
  committed
  e9b883c
Commits on Apr 1, 2017
- Rework unit tests to avoid getInitialModelsPromise()
  smashwilson
  committed
  fed769c
Commits on Apr 5, 2017
- Merge branch 'master' of github.com:atom/github into aw-single-project-regression
  smashwilson
  committed
  ec87a16
- (temporary) console.logstravaganza
  smashwilson
  committed
  909b603
- Use an AsyncQueue for model updates
  smashwilson
  committed
  bf1cd09
- Use .scheduleActiveModelUpdate()
  smashwilson
  committed
  a1d9fca
- :fire: last console.log
  smashwilson
  committed
  fc4e678
Commits on Apr 6, 2017
- Introduce a WorkdirContext to bundle workdir-specific models
  smashwilson
  committed
  872f5c0
- Repository.destroy() is synchronous
  smashwilson
  committed
  765bf0e
- WorkdirContextPool to manage the set of WorkdirContexts
  smashwilson
  committed
  1ec5774
Commits on Apr 7, 2017
- (remove) :checkered_flag: Windows day :checkered_flag:
  smashwilson
  committed
  3cbfefb
- Return a null object from the pool when a directory is not present
  smashwilson
  committed
  129d5e7
- Merge branch 'master' of github.com:atom/github into aw-single-project-regression
  smashwilson
  committed
  187ed07
- Pass a prompt callback to created contexts
  smashwilson
  committed
  785386a
- Restore saved resolution progress state
  smashwilson
  committed
  f71a932
- Change observers get a synchronous Repository
  smashwilson
  committed
  fe59ecd
- Missed one
  smashwilson
  committed
  696585f
- Cache working directory lookups
  smashwilson
  committed
  2740131
- Clear a pool
  smashwilson
  committed
  0432866
- Missed an option in the docs
  smashwilson
  committed
  7bb3a79
- Rework GitHubPackage to use the WorkdirContext objects
  smashwilson
  committed
  1b883bd
Commits on Apr 10, 2017
- Merge branch 'aw-single-project-regression' of github.com:atom/github into aw-single-project-regression
  smashwilson
  committed
  842277f
Commits on Apr 11, 2017
- Handle ENOTDIR when a file path is given
  smashwilson
  committed
  49487e9
- Resolve other models when repository is null
  smashwilson
  committed
  e38e7e6
- Forward observer and repository events from WorkdirContext
  smashwilson
  committed
  769de8b
- Forward events from all WorkdirContexts in a pool
  smashwilson
  committed
  b32a4e2
- Pass options to created WorkdirContexts on set()
  smashwilson
  committed
  3de282c
- It's activeContext, not activeWorkdir
  smashwilson
  committed
  8571ceb
- Subscribe to pool events instead of repository and observer events
  smashwilson
  committed
  d03159f
- Remember and use savedState
  smashwilson
  committed
  993bae3
- Enumerate contextPool, not just activeContext
  smashwilson
  committed
  6eba2ac
- Add newly initialized and clone repositories to the pool
  smashwilson
  committed
  34b06ff
- Right, I renamed that
  smashwilson
  committed
  8694514
- Getter for cleaner testing
  smashwilson
  committed
  6b04880
- Iron out getNextContext
  smashwilson
  committed
  e91ce20
- :fire: unused imports
  smashwilson
  committed
  6ba316e
- HULK COMMIT GIANT TEST OVERHAUL
  smashwilson
  committed
  c318f19
- Merge branch 'master' of github.com:atom/github into aw-single-project-regression
  smashwilson
  committed
  3920f34
- Import Disposables from event-kit
  smashwilson
  committed
  bca6016
- Create NullWorkdirContexts that track working directory
  smashwilson
  committed
  a740ed4
- Right, I changed the way resolution progress state is passed
  smashwilson
  committed
  71dfb8b
- Implement getWorkingDirectory() in FilePatchController
  smashwilson
  committed
  dd38b9f
- Rename activeProjectPath for accuracy
  smashwilson
  committed
  4a7ccf0
- untilRepositories() won't wait until the active context is set
  smashwilson
  committed
  c95a270
- Wait for Repository creation
  smashwilson
  committed
  bbb6fdc
- Replace existing contexts within a pool
  smashwilson
  committed
  03d7471
- Invalidate WorkdirCache entries by subdirectory
  smashwilson
  committed
  5387fd0
- Invalidate the workdir cache when an init has been performed
  smashwilson
  committed
  6648aa1
- Rerender when the Repository loads
  smashwilson
  committed
  e6db052
- Typo fix
  smashwilson
  committed
  b3a324f
- Wait until change observers have started
  smashwilson
  committed
  9aab04c
- Set .started *after* watcher has been started
  smashwilson
  committed
  c29ac8c
- CompositeDisposable.add() no longer supports multiple arguments
  smashwilson
  committed
  a1d8522
- Initialize disposables in the constructor
  smashwilson
  committed
  9e40126
- Return a Disposable from stubbed method
  smashwilson
  committed
  b7866ce
- Fully initialize workspace watchers on Linux
  smashwilson
  committed
  6bc9714
- Instrument context changes and full re-renders
  smashwilson
  committed
  c0f279e
Commits on Apr 13, 2017
- Merge branch 'master' into aw-single-project-regression
  smashwilson
  authored
  7e7419b
- Merge branch 'master' of github.com:atom/github into aw-single-project-regression
  smashwilson
  committed
  b883f2e
- :fire: unused method
  smashwilson
  committed
  e67fe5c
- Rework Repository tests in anticipation of the state machine
  smashwilson
  committed
  5b30c7a
- Additional models to return from Repository methods
  smashwilson
  committed
  4a5a6e7
- `mkdirs` helper to promisify `fs.mkdirs`
  smashwilson
  committed
  8cd8c5b
- Test case to verify State delegates
  smashwilson
  committed
  8ff58fa
- `.clone()` takes one argument
  smashwilson
  committed
  862d60e
- Delegate ALL THE THINGS to the current State
  smashwilson
  committed
  be7672d
- Repository state machine :wrench:
  smashwilson
  committed
  8e44534
- fetch, push, and pull accept a remote name argument
  smashwilson
  committed
  589192c
- Move getRemoteForBranchName() into Repository
  smashwilson
  committed
  6b5f832
- Remote.getNameOr() lets you specify a default
  smashwilson
  committed
  56d277e
- saveDiscardHistory() is a native Repository method
  smashwilson
  committed
  aff481d
- :fire: methods that should no longer be delegated
  smashwilson
  committed
  d1eb89f
- Use getBlobContents() from git strategy from loadHistoryPayload()
  smashwilson
  committed
  70bebc3
- Cache invalidation with a fancy decorator
  smashwilson
  committed
  1332c64
- Refresh explicitly in tests
  smashwilson
  committed
  979b815
Commits on Apr 14, 2017
- Model detached Branches
  smashwilson
  committed
  0d49c45
- Move URL extraction to Remote
  smashwilson
  committed
  5e07c29
- Helper to get the SHA of a working directory
  smashwilson
  committed
  b193c76
- Update buildRepository() for stateful Repositories
  smashwilson
  committed
  c3f3bae
- Detect a Repository's state by name
  smashwilson
  committed
  258e57f
- Delegate a method to respond to filesystem changes
  smashwilson
  committed
  5afdb22
- Adapt to the use of Real Objects for Branches, Remotes, Commits
  smashwilson
  committed
  b011471
- Begin all ResolutionProgress instances empty
  smashwilson
  committed
  64843d5
- Utility methods on change observers
  smashwilson
  committed
  a2e01f0
- Register the Destroyed state
  smashwilson
  committed
  9f48f95
- Default observeFilesystemChange() to a refresh()
  smashwilson
  committed
  9f386d2
- WorkdirContext no longer needs to defer state
  smashwilson
  committed
  caf499b
- Manage WorkdirContext lifecycle correctly within a pool
  smashwilson
  committed
  ef84176
- Introduce an "Absent" state when no working directory is available
  smashwilson
  committed
  d428db3
Commits on Apr 17, 2017
- Use nullBranch and nullRemote in defaultProps
  smashwilson
  committed
  30aa5ae
- Async tempdir helper
  smashwilson
  committed
  5190d63
- Branch and Remote polish
  smashwilson
  committed
  778183e
- Return the `transitionTo` result promise
  smashwilson
  committed
  5794042
- Clear the cache on operation failure too
  smashwilson
  committed
  1b3364e
- Return Branch array from getBranches()
  smashwilson
  committed
  e75eb35
- Delegate `.refresh()` back to Repository
  smashwilson
  committed
  fb27202
- Make nullWorkdirContext a singleton
  smashwilson
  committed
  724285d
- Handle absent Repositories
  smashwilson
  committed
  a734519
- Simplify WorkdirContext tests for synchronous models
  smashwilson
  committed
  d575d68
- Use the nullWorkdirContext singleton
  smashwilson
  committed
  dd88f6f
- No need to .rerender() on repository load
  smashwilson
  committed
  ea1000b
- :fire: unused Disposable cleanup
  smashwilson
  committed
  b7937fd
- Clone and init work with empty Repositories
  smashwilson
  committed
  51320c7
- Always include project path contexts, even if they are empty
  smashwilson
  committed
  818ea83
- Switchboard accessor for clarify in tests
  smashwilson
  committed
  9bcbc98
- Await the right things in GithubPackage tests
  smashwilson
  committed
  3327006
- Wait for context to finish updating
  smashwilson
  committed
  b6dc781
- Boolean logic is hard, okay
  smashwilson
  committed
  a1bffc3
- Await context updates correctly
  smashwilson
  committed
  54d0da7
Commits on Apr 18, 2017
- getTempDir() generates the parent directory itself
  smashwilson
  committed
  730b5b3
- DiscardHistory requires a working directory path, not a function
  smashwilson
  committed
  72d5f17
- Avoid PropTypes warnings by providing null models
  smashwilson
  committed
  ed69556
- Wait for checkout operations to complete
  smashwilson
  committed
  76d9c19
- Merge branch 'master' of github.com:atom/github into aw-go-go-gadget-repository-state-machine
  smashwilson
  committed
  d38a1f7
- Because I changed the behavior of getTempDir for some reason
  smashwilson
  committed
  8268a71
- Don't conceal errors
  smashwilson
  committed
  b23c877
- Always return a Promise from stageFiles and unstageFiles
  smashwilson
  committed
  0ea1b57
- Use .refresh() for invalidation to trigger didUpdate
  smashwilson
  committed
  1b8e85f
- Await props.commit too
  smashwilson
  committed
  bc70ab9
- :fire: that doesn't need to be a thing any more
  smashwilson
  committed
  8c5c5fe
- Prefer "await asser.async" to the "next render" promises
  smashwilson
  committed
  6570cdb
- ResolutionProgress constructor no longer accepts arguments
  smashwilson
  committed
  62cb71b
- PropTypes are our friend
  smashwilson
  committed
  d270367
- destroy() takes more time on AppVeyor
  smashwilson
  committed
  30ec39d
- GitPanel :point_right: GitTab for consistency
  smashwilson
  committed
  8b26484
- :fire: unused imports
  smashwilson
  committed
  26b9b5b
- Default Repository data to null objects
  smashwilson
  committed
  4583a18
- Always emit an update event on state change
  smashwilson
  committed
  658493e
- Hide the Amend checkbox while loading
  smashwilson
  committed
  bd9b66e
- Test the CommitView in the loading state
  smashwilson
  committed
  863d520
- Apply .is-loading to the panel when loading
  smashwilson
  committed
  b25433b
- Grey out controls and text while loading
  smashwilson
  committed
  8e8f3dc
Commits on Apr 19, 2017
- Undetermined state for package activation delay
  smashwilson
  committed
  94acec7
- Give Undetermined its own state probe method
  smashwilson
  committed
  c22b6d1
- Return absentWorkdirContexts from the pool
  smashwilson
  committed
  6c05e1a
- Begin with an Undetermined context instead of an Absent one
  smashwilson
  committed
  adf8d52
- Flatten the State hierarchy
  smashwilson
  committed
  950c14d
- Default implementation of destroy()
  smashwilson
  committed
  c388a4c
- Use behavior probes instead of state probes
  smashwilson
  committed
  0cc01c3
- toString() for debugging handiness
  smashwilson
  committed
  7369cac
- Embiggen Undetermined state timeout
  smashwilson
  committed
  719c15d
- Hide branch and push/pull status bar tiles unless a repo is present
  smashwilson
  committed
  ecefa93
- Merge branch 'master' into aw-single-project-regression
  smashwilson
  authored
  bd1fd8e
- :fire: unnecessary etch.updates
  smashwilson
  committed
  06408fa
- Merge remote-tracking branch 'origin/aw-single-project-regression' into aw-go-go-gadget-repository-state-machine
  smashwilson
  committed
  6a37990
- Init dialog
  smashwilson
  committed
  be0ab10
- Render the InitDialog when no working directory is known
  smashwilson
  committed
  2981190
- createRepositoryForProjectPath() handles paths outside of known projects
  smashwilson
  committed
  076f1d9
- Better errors when attempting to init an existing git repository
  smashwilson
  committed
  4891185
- Change the init message based on context
  smashwilson
  committed
  c66acdb
Commits on Apr 20, 2017
- Introduce behavioral variants of the Undetermined state
  smashwilson
  committed
  9b24ba4
- Create undetermined WorkdirContexts with a behavioral variant
  smashwilson
  committed
  e7807d3
- Heuristically derive the initial context
  smashwilson
  committed
  29416d0
- Pass getLoadSettings to the package
  smashwilson
  committed
  0903db0
- Use initialPaths instead of locationsToOpen
  smashwilson
  committed
  d07e864
- Account for renders that occur while fetching Promise data
  smashwilson
  committed
  bf2b039
- Split Undetermined into LoadingGuess and AbsentGuess
  smashwilson
  committed
  d639648
- Export state constructors as-is
  smashwilson
  committed
  46b2aa3
- Move initial context guess into WorkdirContext
  smashwilson
  committed
  dbe22c4
- Update tests to use static constructor methods
  smashwilson
  committed
  0e57633
- Document Repository states
  smashwilson
  committed
  ec61886
- :fire: unused function
  smashwilson
  committed
  994804d
- Docs docs docs (without a k)
  smashwilson
  committed
  81d8e40
- State transition diagram
  smashwilson
  committed
  f2e771f
- Right, no SVGs in markdown renders
  smashwilson
  committed
  311a7c8
- It helps if the link is right
  smashwilson
  committed
  170d8cc
- Handle the removal of the last project folder
  smashwilson
  committed
  5f80ec2
- Merge pull request #654 from atom/aw-go-go-gadget-repository-state-machine
  smashwilson
  authored
  2080ca4
- File extensions are important in links
  smashwilson
  committed
  288c954
- Merge branch 'master' into aw-single-project-regression
  smashwilson
  authored
  473648f
- Avoid recomputing the active item workdir
  smashwilson
  committed
  8a8f4bd
- Pass even if the Repository already loaded
  smashwilson
  committed
  705ed71

Commits

Commits on Mar 30, 2017

Commits on Apr 1, 2017

Commits on Apr 5, 2017

Commits on Apr 6, 2017

Commits on Apr 7, 2017

Commits on Apr 10, 2017

Commits on Apr 11, 2017

Commits on Apr 13, 2017

Commits on Apr 14, 2017

Commits on Apr 17, 2017

Commits on Apr 18, 2017

Commits on Apr 19, 2017