This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Repository navigation

Improve hunk and line selection - #264

Merged

nathansobo merged 51 commits into

masterfrom

ns-file-patch-selection

Oct 4, 2016

Merged

Improve hunk and line selection#264
nathansobo merged 51 commits into
masterfrom
ns-file-patch-selection

Commits on Sep 23, 2016
- Remove dead code
  Nathan Sobo
  committed
  8d6cbbc
- Start on FilePatchSelection
  Nathan Sobo
  committed
  6ca2187
- Ensure selection is stable after FilePatchSelection.updateHunks
  Nathan Sobo
  committed
  dcf80de
Commits on Sep 24, 2016
- Store selections as absolute indices
  Nathan Sobo
  committed
  da4b761
- Add explicit selectToLine method instead of the `expand` flag
  Nathan Sobo
  committed
  c1e6c22
Commits on Sep 25, 2016
- Allow multiple hunk line selection ranges
  Nathan Sobo
  committed
  916c21c
- Handle multiple selections in FilePatchSelection.updateHunks
  Nathan Sobo
  committed
  0507fc8
- Handle the last line being selected before calling updateHunks
  Nathan Sobo
  committed
  52125ee
- Handle calling updateHunks with an empty array
  Nathan Sobo
  committed
  b50b0a8
- Fix last selected line handling in updateHunks
  Nathan Sobo
  committed
  4117359
- Use FilePatchSelection to manage selections in FilePatchView
  Nathan Sobo
  committed
  8ac8f95
Commits on Sep 26, 2016
- Add selectNext/PreviousLine
  Nathan Sobo
  committed
  7a790dd
- Remove dead code
  Nathan Sobo
  committed
  f20f34f
- Remove log
  Nathan Sobo
  committed
  9e66777
- Store hunkIndex and lineIndex for selection state
  Nathan Sobo
  committed
  ef1127a
- Add selectToNext/PreviousLine
  Nathan Sobo
  committed
  b52a5fd
- :art:
  Nathan Sobo
  committed
  4d99825
- Collapse multiple selections to one when selecting next / previous line
  Nathan Sobo
  committed
  ad5fb4d
- Wire up select next/previous in FilePatchView
  Nathan Sobo
  committed
  0e0b543
- Add hunk selection
  Nathan Sobo
  committed
  d88d1fb
- Assert that selected hunks and lines exist
  Nathan Sobo
  committed
  766b8f0
- Clarify helper names
  Nathan Sobo
  committed
  0a16b89
- Use selectLine in selectNext/PreviousLine
  Nathan Sobo
  committed
  d63c048
- Add selectNext/PreviousHunk
  Nathan Sobo
  committed
  2debf27
- Unfocus test
  Nathan Sobo
  committed
  334640d
- Start on selection modes
  Nathan Sobo
  committed
  5fa6b7a
Commits on Sep 28, 2016
- Consider hunks overlapped by line selections as selected
  Nathan Sobo
  committed
  cb25b6e
- Pass a default value to reduce
  Nathan Sobo
  committed
  7becab9
- Update hunk selection in updateHunks
  Nathan Sobo
  committed
  96a84c9
- :art: spec descriptions
  Nathan Sobo
  committed
  ff11451
- Clean up FilePatchView
  Nathan Sobo
  committed
  e4b1564
Commits on Sep 29, 2016
- Simplify FilePatchSelection by relying on more state
  Nathan Sobo
  committed
  d298c9e
- Fix bugs caused by deepEqual having false positives for sets
  
  Nathan Sobo
  authored and
  kuychaco
  committed
  5f8acbf
- Enable shift-click to select hunk line ranges
  
  Nathan Sobo
  authored and
  kuychaco
  committed
  02e34f9
- Negate existing selections when cmd-click-dragging selected lines
  
  Nathan Sobo
  authored and
  kuychaco
  committed
  a233d3c
Commits on Sep 30, 2016
- Coalesce overlapping/adjacent selections
  
  Nathan Sobo
  authored and
  kuychaco
  committed
  41b46de
- Merge selections across context lines when coalescing
  Nathan Sobo
  committed
  a6326cf
- Truncate intersecting selections when coalescing w/ negative selections
  Nathan Sobo
  committed
  add7f81
- :art:
  Nathan Sobo
  committed
  512b880
- Bail immediately if coalescing with no selections
  Nathan Sobo
  committed
  0d6ee71
- Handle moving to next/previous line with no selection
  Nathan Sobo
  committed
  daf1435
- Select hunks on double-click
  Nathan Sobo
  committed
  1df0d61
- Allow first/last line to be selected with standard bindings
  Nathan Sobo
  committed
  5149b41
- Remove unnecessary coalesce calls
  Nathan Sobo
  committed
  744b35a
- Support select all command in FilePatchView
  Nathan Sobo
  committed
  4fcd6bf
- Fix selected line staging via hunk header button
  Nathan Sobo
  committed
  82f9825
- Remove "focus hunk" commands and rely core movement commands instead
  Nathan Sobo
  committed
  cec4740
Commits on Oct 3, 2016
- Remove unused method parameters
  Nathan Sobo
  committed
  d11b864
- Fix FilePatchController integration tests
  Nathan Sobo
  committed
  49d7f71
Commits on Oct 4, 2016
- Fix FilePatchView tests
  Nathan Sobo
  committed
  e8cbeb0
- Merge remote-tracking branch 'origin/master' into ns-file-patch-selection
  Nathan Sobo
  committed
  2233a13

Commits

Commits on Sep 23, 2016

Commits on Sep 24, 2016

Commits on Sep 25, 2016

Commits on Sep 26, 2016

Commits on Sep 28, 2016

Commits on Sep 29, 2016

Commits on Sep 30, 2016

Commits on Oct 3, 2016

Commits on Oct 4, 2016