This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Repository navigation

Refactoring builders [do not merge] - #1919

Closed

annthurium wants to merge 92 commits into

masterfrom

tt-19-jan-fakey-mc-fakeface

Closed

Refactoring builders [do not merge]#1919
annthurium wants to merge 92 commits into
masterfrom
tt-19-jan-fakey-mc-fakeface

Commits on Jan 14, 2019
- when diff is decided to be "too large", we skip hunk building and return a placeholder filepatch.
  vanessayuenn
  committed
  a8bea5f
- visually display the diff gate
  vanessayuenn
  committed
  e2862ea
Commits on Jan 16, 2019
- experimenting wiht a DelayedPatch but idk
  vanessayuenn
  committed
  a9db48f
- Delayed patch parsing
  
  smashwilson
  and
  vanessayuenn
  committed
  f621d49
- Correct pre-existing markers after building patch hunks
  smashwilson
  committed
  a729493
- :shirt:
  smashwilson
  committed
  68926e5
- get things to render properly first
  vanessayuenn
  committed
  4686cfc
- Accept renderStatusOverrides in ye MultiFilePatch builder
  smashwilson
  committed
  0c3a2a6
- Pass builder options to getFilePatchForPath and getStagedChangesPatch
  smashwilson
  committed
  7db6fb0
- some clean up
  vanessayuenn
  committed
  9de0eae
- click to show diff???
  vanessayuenn
  committed
  e8f372a
- Add a renderStatus to Patch
  smashwilson
  committed
  dc04f49
- Emit events from a FilePatch when its render status changes
  smashwilson
  committed
  f0b8371
- Unit tests for FilePatch render status events
  smashwilson
  committed
  9dad4f7
- Remember changed renderStatus
  smashwilson
  committed
  cd5cc28
- add collapse button to file patch header
  Tilde Ann Thurium
  committed
  7eab119
- Use a Marker instead of a Point to track delayed patch location
  smashwilson
  committed
  b251264
- Track changed renderStatus in CommitPreviewContainer
  smashwilson
  committed
  0bfacb6
- Ditto for CommitDetailContainer
  smashwilson
  committed
  40cde30
- fix bad parens in mfp builder
  annthurium
  committed
  be2ab8f
- don't render pull request comments if patch exceeds large diff threshold
  annthurium
  committed
  e28522e
- use a Map to avoid iterating through patches
  annthurium
  committed
  b66c88c
- deal with null patches
  annthurium
  committed
  98fbfc9
- :shirt:
  annthurium
  committed
  ccf2a99
- danananana PROP TYPES
  annthurium
  committed
  26ee209
Commits on Jan 17, 2019
- also check for COLLAPSED patch state
  annthurium
  committed
  010cd56
- honk if you like test helpers
  annthurium
  committed
  cd2b7f9
- clean up pr comments builder
  annthurium
  committed
  8324cb3
- [wip] add tests for `isPatchTooLargeOrCollapsed`
  annthurium
  committed
  ee6c9c2
- Test case for Patch Marker movement
  smashwilson
  committed
  0733676
- Extract LayeredBuffer class and use it consistently in Patch logic
  smashwilson
  committed
  1237458
- Rename LayeredBuffer to PatchBuffer
  smashwilson
  committed
  f963e75
- Begin an "atomic" (with respect to markers) Modification API
  smashwilson
  committed
  6df1380
- import LARGE_DIFF_THRESHOLD
  annthurium
  committed
  3b34099
- Preserve Markers that begin or end at a Modification's insertion point
  smashwilson
  committed
  49b406d
- PatchBuffer::extract() to slice a Range out and preserve its markers
  smashwilson
  committed
  a2d453c
- Unit test for inserting one PatchBuffer into another
  smashwilson
  committed
  34e104a
Commits on Jan 18, 2019
- actually trigger expanding and collapsing from `FilePatchHeaderView`
  annthurium
  committed
  dfc2fee
- change the chevron icon direction depending on collapsed prop
  annthurium
  committed
  ebdec24
- Implement appendPatchBuffer()
  smashwilson
  committed
  01b82f0
- Translate Markers when extracting and appending PatchBuffers midline
  smashwilson
  committed
  2d7c2f4
- Renamings
  smashwilson
  committed
  03e03f3
- Rename Inserter methods as "insert..." instead of "append..."
  smashwilson
  committed
  400d1b8
- Produce Maps of equivalent Markers after extract/insert PatchBuffers
  smashwilson
  committed
  37f9ae6
- Inserter::markWhile() to mark all changes made in a block
  smashwilson
  committed
  498c720
- Rewrite buildHunks() to use an Inserter
  smashwilson
  committed
  5c8181e
Commits on Jan 22, 2019
- [wip] make patch model use `nextLayeredBuffer`
  annthurium
  committed
  1a74e83
- PatchBuffer::inspect() to debug marker placement
  smashwilson
  committed
  510c887
- PatchBuffer::findAllMarkers() to query markers across all layers
  smashwilson
  committed
  18ff065
- Clip insertion point to valid buffer positions
  smashwilson
  committed
  5283be0
- Fluent APIs
  smashwilson
  committed
  c56becb
- No need to manually touch up patch/hunk markers
  smashwilson
  committed
  d6e5947
- Insert newlines *between* consecutive patches, hunks, regions
  smashwilson
  committed
  4c39a4b
- Need IIFEs for callbacks created within loops
  smashwilson
  committed
  62951be
- buildHunks() always inserts at the end
  smashwilson
  committed
  0187f4c
- :fire: trailing newline
  smashwilson
  committed
  07f3c88
- Remove console.logs :eyes:
  smashwilson
  committed
  f4ea1a2
- Mark zero-length patches
  smashwilson
  committed
  57c03e1
Commits on Jan 23, 2019
- [wip] make Patch model tests use a PatchBuffer
  annthurium
  committed
  869ec0e
- :fire: .only
  annthurium
  committed
  d1fcf70
- DelayedPatch :point_right: HiddenPatch
  smashwilson
  committed
  d13d184
- More trailing newlines
  smashwilson
  committed
  d25db25
- updateMarkers methods to consume marker Maps
  smashwilson
  committed
  92a1130
- Implement HiddenPatch
  smashwilson
  committed
  70ea302
- Get starting and ending Marker sets
  smashwilson
  committed
  24515a1
- Create a HiddenFilePatch for diff sets that are too large
  smashwilson
  committed
  f27f5ab
- Move collapsing and expanding to MFP
  smashwilson
  committed
  36ac87c
- Use getRenderStatus() methods
  smashwilson
  committed
  4bba2f4
- Use MFP-level expand and collapse methods
  smashwilson
  committed
  5ca5f12
- Show specific marker layers in PatchBuffer::inspect()
  smashwilson
  committed
  fae0a50
- Implement inspect() methods on patch model classes
  smashwilson
  committed
  219a409
- destroyMarkers() calls to... destroy... the markers
  smashwilson
  committed
  9767a87
- Build hunk data for expanding too-large patches on the correct buffer
  smashwilson
  committed
  b1d7ff5
- Fix up Marker-keyed maps in MFP after expand or collapse
  smashwilson
  committed
  fc3d89c
- NullPatch implementations of adjacent-marker methods
  smashwilson
  committed
  e1a1a5c
- Defer insertPatchBuffer()'s callback until the marker map is populated
  smashwilson
  committed
  37c53ca
- More collapse and expand work
  smashwilson
  committed
  9d174a3
- Find adjacent FilePatches by array index instead of markers
  smashwilson
  committed
  a0ae01c
- Remove unused argument
  smashwilson
  committed
  cba6f05
- Touch up expected marker range
  smashwilson
  committed
  715f10a
- Correct expected Hunk header
  smashwilson
  committed
  cff0d29
- Build what-the-diff output instead of just model objects
  smashwilson
  committed
  2d7c81a
- Fix building symlink related FilePatches
  smashwilson
  committed
  537fd0e
- ::reMarkOn() accepts a PatchBuffer
  smashwilson
  committed
  6685330
- Adapt MultiFilePatch tests to model changes
  smashwilson
  committed
  2cd40d3
Commits on Jan 24, 2019
- Distinguish between unset and null files
  smashwilson
  committed
  5af6a87
- Set file patch status on symlink pairs
  smashwilson
  committed
  8bab5ed
- fp3 isn't supposed to be a symlink change?
  smashwilson
  committed
  97154cb
- Use MFP-level collapse and expand functions
  smashwilson
  committed
  5b35a4f
- Retain the TextBuffer within a PatchBuffer
  smashwilson
  committed
  ecb49ea
- NullPatch::reMarkOn() accepts a PatchBuffer
  smashwilson
  committed
  e6a74b0
- nits nits nits
  annthurium
  committed
  aa41930

Commits

Commits on Jan 14, 2019

Commits on Jan 16, 2019

Commits on Jan 17, 2019

Commits on Jan 18, 2019

Commits on Jan 22, 2019

Commits on Jan 23, 2019

Commits on Jan 24, 2019