This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Repository navigation

Commit Preview - #1767

Merged

kuychaco merged 416 commits into

masterfrom

commit-preview

Nov 20, 2018

Merged

Commit Preview#1767
kuychaco merged 416 commits into
masterfrom
commit-preview

This pull request is big! We're only showing the most recent 250 commits

Commits on Nov 7, 2018
- Patch tests are :white_check_mark: :fireworks:
  smashwilson
  committed
  45c2ddf
- Adapt callers to changed buildStagePatchForLines() return value
  smashwilson
  committed
  dc0c14d
- Catch that other "getFilePatchesContaining() returns a Set" call
  smashwilson
  committed
  c148a8d
- Cover the last few Patch methods
  smashwilson
  committed
  188d2ea
- Bring NullPatch up to date
  smashwilson
  committed
  2fff972
- missed a rename oops
  vanessayuenn
  committed
  462dffd
- FilePatch tests :white_check_mark: + coverage
  smashwilson
  committed
  6b1744b
- :fire: dot only
  smashwilson
  committed
  c8c0ef0
- :fire: another dot only
  smashwilson
  committed
  772c36d
- getpatchlayer
  vanessayuenn
  committed
  bbfd510
- WIP MultiFilePatch tests
  smashwilson
  committed
  ae8a4fb
- probably should be for..in since we're interating through an array
  vanessayuenn
  committed
  2b1b4a9
- fix ChangedFileContainer tests
  Tilde Ann Thurium
  committed
  1418498
- Merge branch 'commit-preview' of github.com:atom/github into pr-1767/atom/commit-preview
  vanessayuenn
  committed
  8d7e965
- Merge remote-tracking branch 'origin' into pr-1767/atom/commit-preview
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  4b12015
Commits on Nov 8, 2018
- fix some of the RootController tests
  Tilde Ann Thurium
  committed
  8a49372
- WIP - why `RootController` tests no worky
  Tilde Ann Thurium
  committed
  680f373
- fix test syntax oops
  Tilde Ann Thurium
  committed
  1513921
- Correctly invalidate cache in `applyPatchToIndex` based on MFP file paths
  kuychaco
  committed
  43199ee
- :fire: duplicate `getPatchLayer`
  kuychaco
  committed
  05dff68
- :fire: unused import
  kuychaco
  committed
  15039ba
- Clear and remark patch layer in `adoptBufferFrom`
  
  kuychaco
  and
  smashwilson
  committed
  344f4b9
- Add missing methods to NullPatch
  kuychaco
  committed
  eb714c5
- Restyle file and hunk headers
  simurai
  committed
  8d9aa25
- Remove long-obsolete .setState() calls in RootController tests
  
  smashwilson
  and
  Tilde Ann Thurium
  committed
  1b1cbd2
- Update RootController discard and undo tests to use MultiFilePatches
  
  smashwilson
  and
  Tilde Ann Thurium
  committed
  8c004aa
- Accept a MultiFilePatch in Present::applyPatchToWorkdir()
  
  smashwilson
  and
  Tilde Ann Thurium
  committed
  f3809cb
- Construct partial stage patches on an existing non-empty TextBuffer
  smashwilson
  committed
  86a8da1
- Passing test for cross-file partial stage patch generation
  smashwilson
  committed
  181adf8
- Preserve FilePatch order in getFilePatchesContaining()
  smashwilson
  committed
  972cab7
- make CommitPreviewContainer tests pass
  
  Tilde Ann Thurium
  and
  vanessayuenn
  committed
  836207f
- fix nullpatch being displayed
  vanessayuenn
  committed
  07cee58
- fix commitpreviewitem tests
  
  vanessayuenn
  and
  Tilde Ann Thurium
  committed
  ddd0630
- Turns out we don't actually need that Set
  smashwilson
  committed
  6bfe025
- We actually care about typechanges, not just having a symlink
  smashwilson
  committed
  1eff20f
- MultiFilePatch tests: (un)staged patch generation, predicates
  smashwilson
  committed
  ccd4eb6
- filePatch is soooo last week; we are on multiFilePatch now. 🆒
  vanessayuenn
  committed
  d52b987
- we don't care about active/inactive anymore... i think.
  vanessayuenn
  committed
  d03c37c
- no `.only`
  vanessayuenn
  committed
  467a33e
- Full MultiFilePatch coverage for everything but getNextSelectionRange()
  smashwilson
  committed
  ea76f59
- new clone method for MFP
  vanessayuenn
  committed
  c6a8aa0
- use the new clone method in MFP view test
  vanessayuenn
  committed
  4ac8af8
- import the right thing
  vanessayuenn
  committed
  3908ffc
- use this.constructor.name for metrics
  Tilde Ann Thurium
  committed
  44bc9b7
- replace usages of old clone method with those of the new one
  vanessayuenn
  committed
  bc86c23
- One more thing...
  vanessayuenn
  committed
  634a391
- Make the MultiFilePatch constructor like the others
  smashwilson
  committed
  973566d
- Return real Ranges
  smashwilson
  committed
  a3ef82a
- Use .clone() within MultiFilePatch
  smashwilson
  committed
  37de91a
- Test fixture builders for the MultiFilePatch models
  smashwilson
  committed
  ccced0b
- Default newFile to oldFile because they're almost always the same
  smashwilson
  committed
  5294545
- Can't use the same names for properties and methods
  smashwilson
  committed
  8fc07fa
- Forgot the first argument to .appendMarked()
  smashwilson
  committed
  483c69f
- First batch of examples that use the builder API
  smashwilson
  committed
  8547505
- Build real Ranges in Patch methods
  smashwilson
  committed
  f3a8b1f
- Delegate getFirstChangeRange() to the Patch
  smashwilson
  committed
  b6176ec
- Forward .status() and .addHunk() to PatchBuilder
  smashwilson
  committed
  566b9e9
Commits on Nov 9, 2018
- fix MultiFilePatchController tests
  Tilde Ann Thurium
  committed
  73d88c0
- :fire: mount
  Tilde Ann Thurium
  committed
  e62f508
- I fuck up partial staging more often than not.
  Tilde Ann Thurium
  committed
  e6561aa
- :shirt:
  Tilde Ann Thurium
  committed
  1ece7eb
- it was the missing brackets in the parlor with the lead pipe.
  Tilde Ann Thurium
  committed
  513e83c
- that's not how you get the hunks
  Tilde Ann Thurium
  committed
  4f80490
- Add more spacing between files
  simurai
  committed
  f9930e5
- Make text selections blue
  simurai
  committed
  dfdbd47
- Remove background color from hunks
  simurai
  committed
  8da27e6
- Fix cursor line on diffs
  simurai
  committed
  70b4dee
- Add borders to hunk buttons
  simurai
  committed
  4280a30
- :fire: Remove gutter background
  simurai
  committed
  c898ad6
- Mark regions with exclusive: true to avoid stretching markers
  smashwilson
  committed
  53177a8
- It helps if you actually call that block
  smashwilson
  committed
  5bebe03
- Initialize default regions before computing hunk row counts
  smashwilson
  committed
  9b69f0e
- Compute valid hunk start rows
  smashwilson
  committed
  e7feca7
- It helps if you call methods that actually exist
  smashwilson
  committed
  1475fce
- Mark to the end of the previous line
  smashwilson
  committed
  c514170
- Allow nullFiles in FilePatches
  smashwilson
  committed
  d81a9cc
- Another method/property name collision
  smashwilson
  committed
  e5d0b95
- fix exec mode change tests
  vanessayuenn
  committed
  b7a4dc7
- fix hunk headers test
  vanessayuenn
  committed
  ec70e50
- Allow empty blocks for addHunk() and addFilePatch() to accept defaults
  smashwilson
  committed
  e0855f6
- Right right that expects an Array
  smashwilson
  committed
  1fd0b0d
- fix hunk lines tests
  vanessayuenn
  committed
  cd4ec37
- That rename we were just talking about
  smashwilson
  committed
  13ad648
- MultiFilePatch tests so far
  smashwilson
  committed
  cca116e
- use the new shiny `multiFilePatchBuilder` ✨
  vanessayuenn
  committed
  3c3d8ba
- replace old buildMultiPatch method with multiFilePatchBuilder
  vanessayuenn
  committed
  5a16641
- nonewline is its own special ting
  vanessayuenn
  committed
  6679c9c
- greenify open file tests
  vanessayuenn
  committed
  fc1faa7
- remove old builder methods from mfp view test suite
  vanessayuenn
  committed
  a142e52
- fix hunk navigation tests
  
  vanessayuenn
  and
  Tilde Ann Thurium
  committed
  c0a296e
- fix typo in patch building for mfp file opening tests
  Tilde Ann Thurium
  committed
  2bb78b0
- Break out of the correct loop
  smashwilson
  committed
  1fc0d85
- getNextSelectionRange() tests :tada:
  smashwilson
  committed
  3603a76
- :fire: unused imports, beforeEach, and lets
  smashwilson
  committed
  201033e
- Fix MultiFilePatchController tests
  kuychaco
  committed
  02407d3
- Test coverage for .clone()
  smashwilson
  committed
  11e78f4
- getFirstChangeRange() returns a real Range object
  smashwilson
  committed
  c667d3e
- Implement .isEqual() on MultiFilePatch the dumbest possible way
  smashwilson
  committed
  aa1e8bf
- The method is called .anyPresent() on a MultiFilePatch
  smashwilson
  committed
  e686a1f
- Reword spec names to reflect MultiFilePatches being returned
  smashwilson
  committed
  ce8363b
- fix buildFilePatch null patch test
  Tilde Ann Thurium
  committed
  d12e3fd
- watchWorkspaceItem tests :white_check_mark: + :100:
  smashwilson
  committed
  47aeebe
- Use `anyPresent` instead of `isPresent`
  kuychaco
  committed
  a7a345b
- Check status on individual filePatch instead of MFP
  kuychaco
  committed
  0c8f000
- Set pull.rebase config to false in `setUpLocalAndRemoteRepositories`
  kuychaco
  committed
  7cd5cfd
- Move coveralls report to after_script
  smashwilson
  committed
  4886129
- Only call `discardLines` if MFP has a single file patch
  kuychaco
  committed
  7b4078f
- Fix `buildFilePatch`
  kuychaco
  committed
  3908db1
- Fix `buildMultiFilePatch` tests
  kuychaco
  committed
  37967ee
Commits on Nov 10, 2018
- Fix `Open in File` and make it work for multiple files
  kuychaco
  committed
  3a3c68a
- workshopping button text
  Tilde Ann Thurium
  committed
  52634b9
- Finish up that question/comment...
  kuychaco
  committed
  73f5d69
- Fix `undoLastDiscard`
  kuychaco
  committed
  dc1c009
- :memo: add new components to React atlas
  Tilde Ann Thurium
  committed
  6ab88e8
- Fix `undoLastDiscard` test for MultiFilePatchView
  kuychaco
  committed
  a92f21c
- Update button text in tests
  kuychaco
  committed
  a2d5c99
- Fix tests for opening file when there is only a single file patch
  kuychaco
  committed
  a60cfc5
- :fire: console.logs
  kuychaco
  committed
  1c711f0
- :shirt: don't shadow `fp`
  kuychaco
  committed
  36e1e5f
- Make commit preview button styled as `secondary` rather than `primary`
  
  kuychaco
  and
  mattmattmatt
  committed
  54b23c9
- :fire: dot only
  smashwilson
  committed
  fd800ef
Commits on Nov 11, 2018
- Merge branch 'master' into commit-preview
  smashwilson
  committed
  005e56f
Commits on Nov 12, 2018
- Merge branch 'master' of github.com:atom/github into commit-preview
  smashwilson
  committed
  2640e81
- :fire: dead code in patch models
  smashwilson
  committed
  549bd86
- Delete unused Region range accessors
  smashwilson
  committed
  7f3af52
Commits on Nov 13, 2018
- Explicitly construct empty Patches
  smashwilson
  committed
  0875df3
- Cover remaining lines in MultiFilePatchView::componentDidMount()
  smashwilson
  committed
  44d7245
- Cover FilePatchHeaderView action properties
  smashwilson
  committed
  a207ad2
- Symlink changes apply to typechange patches, not any patch with a symlink
  smashwilson
  committed
  ade143e
- Test coverage for bulk typechange and mode change patch toggling
  smashwilson
  committed
  01358f4
- Turns out .findMarkers({intersectsRow}) normalizes its argument
  smashwilson
  committed
  474c25f
- Cover that last line in MultiFilePatchController
  smashwilson
  committed
  7209488
- Always require a layeredBuffer
  smashwilson
  committed
  08fa778
- More unused isEqual methods
  smashwilson
  committed
  4783803
- Remove unused-slash-broken FilePatch forwarding methods
  smashwilson
  committed
  cca1ab5
- Unit tests for commit preview stub item creation
  smashwilson
  committed
  3180f44
- No need for a default arg there
  smashwilson
  committed
  c3e6d89
- Register github:toggle-commit-preview in non-dev-mode
  smashwilson
  committed
  35a7aaa
- Test coverage for RootController change
  smashwilson
  committed
  058dd0f
- fix bug in discardRows
  vanessayuenn
  committed
  5d30f13
- test was setup incorrectly too :ohno:
  vanessayuenn
  committed
  50232b0
- Those tests worky now :wink:
  smashwilson
  committed
  e364b0c
- Test for RootController::discardLines() with multiple patches
  smashwilson
  committed
  e8a911a
- Coverage for timing-dependent bits of Repository::saveDiscardHistory()
  smashwilson
  committed
  21c91d8
- `github:open-file` --> `github:jump-to-file`
  kuychaco
  committed
  e58e8b0
- Rename context menu item from "Open File" to "Jump to File"
  kuychaco
  committed
  d517b2e
- :art: test description wording
  kuychaco
  committed
  f58035a
- MultiFilePatch predicate to determine if a set of rows spans files
  smashwilson
  committed
  aadfc9c
- Track selections that span file patches in the MultiFilePatchController
  smashwilson
  committed
  f9c2ebc
- Notify the selectedRowsChanged prop with file-spanning selection status
  smashwilson
  committed
  2d7e71a
- "Jump to file" or "Jump to files" button caption
  smashwilson
  committed
  f61d5dd
- :fire: unused import
  smashwilson
  committed
  a9ed6cb
- Accept a pending argument in openFile action method
  smashwilson
  committed
  c068bbf
- Unit tests for opening multiple files
  smashwilson
  committed
  b653c0f
- Update file spanning state when manipulating selected rows manually
  smashwilson
  committed
  65a8c22
Commits on Nov 14, 2018
- Jump to correct file if there is no diff selection for file
  kuychaco
  committed
  a367b78
- Jump to first changed line
  kuychaco
  committed
  7a18876
- Drop the rest in an `else` clause
  kuychaco
  committed
  7bd749c
- Check for existence of `selectedFilePatch` before accessing methods on it
  kuychaco
  committed
  1685f11
- Don't mistake filePatch param with command event
  kuychaco
  committed
  bed19dc
- Oops we want to be getting the keys of `cursorsByFilePatch`
  kuychaco
  committed
  2a70de1
- Pass the right argument for pending panes
  kuychaco
  committed
  62be5a4
- Add tests for jumping to file from header button
  kuychaco
  committed
  18a08d9
- :art: test to get us back to 100% test coverage of new lines
  kuychaco
  committed
  4fe18c5
- :shirt:
  smashwilson
  committed
  c3a1d78
- Merge branch 'master' into commit-preview
  smashwilson
  committed
  5b6f364
- Delete extraneous test that slipped in with the merge conflict
  smashwilson
  committed
  df837c8
- Move test changes into MultiFilePatchController
  smashwilson
  committed
  5e123b5
- Fix error where getFilePath is not a function on a CommitPreviewItem
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  0adec32
- props only work if you pass them to child components
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  3a62b79
- :art: Make UI more consistent
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  bc58a8a
Commits on Nov 15, 2018
- we don't need to test for no stinkin tooltips
  Tilde Ann Thurium
  committed
  f49d4db
- Explicitly only render Undo Discard button if ChangedFileItem
  kuychaco
  committed
  1fc35c4
- Explicitly only render Undo Discard button if ChangedFileItem
  kuychaco
  committed
  c7535ce
- Add `itemType` prop types for :shirt:
  kuychaco
  committed
  1f68596
- Make basename bold in FilePatchHeaderView
  kuychaco
  committed
  4b53ba7
- Fix tests to include itemType
  kuychaco
  committed
  ea07e4d
- Update docs/react-component-atlas.md
  
  kuychaco
  and
  annthurium
  authored
  5bfd3d0
- Update docs/react-component-atlas.md
  
  kuychaco
  and
  smashwilson
  authored
  989c90d
- :world: CommitPreviewItem is beneath RootController, not GitHubTabItem
  smashwilson
  committed
  a16e7f2
- Use an object spread for that data why not
  smashwilson
  committed
  64c9608
- Pass a Decoration's className to the created DOM element
  smashwilson
  committed
  9aa1a60
- Set and style a more specific CSS class for control blocks
  smashwilson
  committed
  3d63ab0
- File.modes constants for well-known file modes
  smashwilson
  committed
  90295f4
- Use File mode constants where possible
  smashwilson
  committed
  8fc267f
- Go into more detail on why that opener is necessary
  smashwilson
  committed
  0ec9039
- tweak symlink changes styles
  Tilde Ann Thurium
  committed
  707f136
- executable mode change styling tweaks
  Tilde Ann Thurium
  committed
  43c16bf
- :fire: unused cache key for stagedChangesSinceParentCommit
  kuychaco
  committed
  04ed3c8
Commits on Nov 16, 2018
- Use `path.sep` to join dirname and basename
  smashwilson
  committed
  b48fceb
- Merge branch 'master' of github.com:atom/github into commit-preview
  smashwilson
  committed
  209961d
- Avoid double "\\ No newline at end of file"
  smashwilson
  committed
  da9fe4c
- Skip filesystem events with no path
  smashwilson
  committed
  6147c86
- Remove unnecessary <Fragment>
  smashwilson
  committed
  f6f56d6
- Wait for new unstaged patch to arrive
  smashwilson
  committed
  b7049ee
- Adapt the expected path separator to the current platform
  smashwilson
  committed
  83ccf8f
- Default itemType to avoid the PropTypes warning
  smashwilson
  committed
  1325650
- Workspace item watcher only cares about active items
  kuychaco
  committed
  da87fa7
- :fire: props that aren't used in `CommitPreviewItem`
  kuychaco
  committed
  098edb4
- :fire: mysterious handleClick prop in MultiFilePatchController
  kuychaco
  committed
  8362279
- Invalidate `stagedChanges` key when undoing last commit or head moves
  kuychaco
  committed
  7eb7db0
- :fire: useEditorAutoHeight since we are now using a single editor
  kuychaco
  committed
  cd7003a
- Actually we want autoHeight set to false on AtomTextEditor
  kuychaco
  committed
  218d6cb
- :fire: .only
  kuychaco
  committed
  1c1b2d2
- 📝 comment for `intersectRows`
  vanessayuenn
  committed
  3b5d030
- :fire: unnecessary button class name
  Tilde Ann Thurium
  committed
  d599b3c
- compare multifilepatches with toString()
  
  vanessayuenn
  and
  kuychaco
  committed
  d360bd5
- change variable name to make the logic more clear
  
  vanessayuenn
  and
  kuychaco
  committed
  111108e
- Activate the commit preview on cmd-left from the button
  smashwilson
  committed
  42f957b
- MultiFilePatchView prop rename
  smashwilson
  committed
  9ebb954
- Pass surface callback through MultiFilePatchController
  smashwilson
  committed
  2c89cdb
- Bring the keymap up to date
  smashwilson
  committed
  7c59876
- ChangedFileController to control surfacing behavior for ChangedFileItems
  smashwilson
  committed
  71f9da7
- CommitPreviewController to interpret surface as surfaceToCommitPreview
  smashwilson
  committed
  1bc9688
- Render a ChangedFileController within the container
  smashwilson
  committed
  dd90907
- Destroy the atomEnv
  smashwilson
  committed
  55b6f9e
- Render a CommitPreviewController within CommitPreviewContainer
  smashwilson
  committed
  4061824
- Add missing PropTypes to the CommitPreviewItem
  smashwilson
  committed
  48ea0b5
- Unconditional CommitPreviewItem activation for github:dive binding
  smashwilson
  committed
  9b4ffc4
- Imperatively select the commit preview button
  smashwilson
  committed
  fe3aa61
- GitTabView commit preview focusing
  smashwilson
  committed
  97f803e
- Forward surfaceToCommitPreviewButton to the GitTabController
  smashwilson
  committed
  e809b5e
- Method to surface and focus the commit preview button
  smashwilson
  committed
  f4e844a
- :fire: debugger
  smashwilson
  committed
  632349f
- Revert "compare multifilepatches with toString()"
  kuychaco
  committed
  7282f0f
- package-lock updates
  kuychaco
  committed
  a0dafda
- Add logic to `getNextSelectionRange` so that selection remains at bottom when last line is staged
  
  kuychaco
  and
  vanessayuenn
  committed
  1685484
- Test that bottom-most line is selected after staging bottom-most line
  kuychaco
  committed
  8be43e5
- Add more comments to explain logic in `getNextSelectionRange`
  
  kuychaco
  and
  vanessayuenn
  committed
  c4d0dec
Commits on Nov 17, 2018
- WIP Fix one thing, break another =/. Fix marker for patches w/ no hunks
  kuychaco
  committed
  d16b900
- Add test for marker range for a patch with no hunks
  kuychaco
  committed
  111c0c7
- Ensure that marker range for no-hunk patch is not affected by hunks after
  kuychaco
  committed
  c5c2c89
- Throw error if too many markers found (to help with debugging)
  kuychaco
  committed
  1acd91e
- :fire: .only
  kuychaco
  committed
  d33f3e9
Commits on Nov 19, 2018
- Revert "Throw error if too many markers found (to help with debugging)"
  smashwilson
  committed
  e34e46a
- add missing props to CommitPreviewItem tests
  Tilde Ann Thurium
  committed
  5f1f65d
- fix integration tests for file patch
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  d02451e
- add test for `surfaceToCommitPreviewButton` in `RootController`
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  764b6e8
- test that getFileMode returns the correct file mode for symlinks
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  9b15735
Commits on Nov 20, 2018
- test file mode for executable files in git-strategies test
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  3c97dca
- test that repository.updateCommitMessageAfterFileSystemChange handles events with no path property
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  f8e4aae
- maybe make windows filemode happy?
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  bfaacb4
- istanbul ignore test-only code
  
  Tilde Ann Thurium
  and
  kuychaco
  committed
  358adbb
- Test that getPanesWithStalePendingFilePatchItem ignores CommitPreviewItems
  kuychaco
  committed
  1a3e5a4
- :shirt:
  Tilde Ann Thurium
  committed
  f51c570
- fix misaligned line numbers in file mode changes
  
  committed
  e03ce4d
- Check that `getFileMode` works for untracked symlink files
  
  kuychaco
  and
  Tilde Ann Thurium
  committed
  27373b4
- Fix `undoLastDiscardFromCoreUndo` for keyboard users
  kuychaco
  committed
  27ca512
- Fix test for undoing last discard from `core:undo`
  kuychaco
  committed
  7b5935d
- Restyle mode changes
  simurai
  committed
  8e5d9ee

Commits

Commits on Nov 7, 2018

Commits on Nov 8, 2018

Commits on Nov 9, 2018

Commits on Nov 10, 2018

Commits on Nov 11, 2018

Commits on Nov 12, 2018

Commits on Nov 13, 2018