This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Repository navigation

RFC for Pull Request Review - #1706

Merged

smashwilson merged 39 commits into

masterfrom

aw/pr-review-rfc

Oct 4, 2018

Merged

RFC for Pull Request Review#1706
smashwilson merged 39 commits into
masterfrom
aw/pr-review-rfc

Commits on Sep 27, 2018
- Screw it, press commit
  smashwilson
  committed
  43b33e3
- and not or
  smashwilson
  committed
  6af2960
Commits on Sep 28, 2018
- A little more justification
  smashwilson
  committed
  48a31dc
- Prose for the rest of the UI components
  smashwilson
  committed
  438a9e6
- Drawbacks and rationale
  smashwilson
  committed
  bcc742d
- Review creation
  smashwilson
  committed
  e5410a3
- Use real headers
  smashwilson
  committed
  3b7ac4a
- Kind of answered that one myself
  smashwilson
  committed
  85ba758
- Add a mock-up for non-current pull request tiles
  smashwilson
  authored
  194d362
Commits on Oct 1, 2018
- Update review-list mockup
  simurai
  authored
  81a53e0
- Add reviews-tab mockup
  simurai
  authored
  12532be
- Update pending-review mockup
  simurai
  authored
  3279a26
- Replace changes and reviews tab mockups
  simurai
  authored
  d902dcf
Commits on Oct 2, 2018
- "position: sticky" navigation and filter banner in "Changes" tab
  
  smashwilson
  and
  kuychaco
  committed
  64f2433
- Unify the "Reviews" and "Changes" tabs
  
  committed
  0cb878e
- Emphasize review authoring and finalization on the "Changes" tab
  
  committed
  e50fa72
- Mention the review summary list
  smashwilson
  committed
  884c39d
- Reaction emoji ftw :cake: :tada:
  
  smashwilson
  and
  Tilde Ann Thurium
  committed
  c37fe1f
- Explicit "single one-off comment" handling
  
  smashwilson
  and
  Tilde Ann Thurium
  committed
  c45f9de
- Add answers to some of our questions :smile:
  smashwilson
  committed
  792d9d0
- Oh hey that works
  smashwilson
  committed
  5465f71
- Dependency graph why not
  smashwilson
  committed
  ea33834
- Update iconography description
  smashwilson
  committed
  d4b153b
- Suggestion for reducing confusion when a different PR is open
  
  smashwilson
  and
  kuychaco
  committed
  6bccb4b
- Remove non-current pull request tile changes
  smashwilson
  committed
  759884a
- IssueishDetailItem not IssueishPaneItem
  smashwilson
  committed
  af4c794
- Include @kuychaco's IssueishDetailItem refocus idea :lightbulb:
  
  committed
  6313744
- Create a pending review if one is not present
  
  smashwilson
  and
  Sarah Guthals
  committed
  2ab74b5
Commits on Oct 3, 2018
- Update RFC to reflect editor-first design
  
  kuychaco
  and
  simurai
  committed
  a7b7bae
Commits on Oct 4, 2018
- Incorporate feedback
  
  committed
  cd41db4
- Add in-line comments back
  
  kuychaco
  and
  smashwilson
  committed
  29c6a6e
- Merge pull request #1712 from atom/ku/pr-review-rfc-editor-focus
  smashwilson
  authored
  58863e1
- Mark remaining TODOs as :construction:
  smashwilson
  committed
  ea3973b
- Add an Explanation section for in-editor comment rendering
  smashwilson
  committed
  2750281
- Move diff editability questions to "answered during implementation"
  smashwilson
  committed
  c445668
- Move this question from "before merge" to "during implementation"
  smashwilson
  committed
  17ec937
- Dependency graph bump
  smashwilson
  committed
  e6c34ab
- Give it a number :tada:
  smashwilson
  committed
  bad5770
- Status: accepted :hammer:
  smashwilson
  committed
  5ad24e6

Commits

Commits on Sep 27, 2018

Commits on Sep 28, 2018

Commits on Oct 1, 2018

Commits on Oct 2, 2018

Commits on Oct 3, 2018

Commits on Oct 4, 2018