This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
Call FilePatchController methods on the "real item" - #1400
Merged
Merged
Conversation
smashwilson
added a commit
that referenced
this pull request
Apr 19, 2018
Call FilePatchController methods on the "real item"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using getRealItem() to identify pane items that are
FilePatchControllers, but we're callingFilePatchControllermethods directly on the pane item even if it isn't aFilePatchController.Not adding a regression test because StagingView is pending a React port and adding more tests would make it that much more painful 😅
Fixes #1396.