This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
Upgrade to Enzyme 3 - #1386
Merged
Merged
Upgrade to Enzyme 3#1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enzyme 3 is a total rewrite that supports a broad range of React versions by means of an "adapter". I'm splitting this out of #1174 in hopes of being able to get us back on the latest stable React in smaller chunks of work.
Almost all of the failures I've hit so far have been what @BinaryMuse identified at #1174 (comment), by which I mean "apply
.update()generously". Hopefully by now all of the blockers that she identified in that issue have been ironed out upstream? 🤞 It certainly looks like the issues she linked are closed, at least.Remaining failures