This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
Remove staging event - #101
Merged
Merged
Conversation
Contributor
Author
|
There are a few more tests I need to update, and some new tests I need to add. But the bulk of this should be done. |
Contributor
Author
|
Also I'm so 💔 that the new fixture repositories ruins what would have otherwise been a glorious diffstat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have this whole complicated mechanism around propagating the staging event and then unwrapping it. It adds a lot of complexity and indirection. And it makes our models fat.
Let’s not do that anymore.