Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Opening github from the toolbar doesn't open after closing pane #891

Closed

Description

@ungb

Prerequisites

Description

Opening Github or Git Pane after closing the pane adds the pane back to the dock, but doesn't open the dock until you click again.

Steps to Reproduce

  1. Open Atom.
  2. If github package is open, close it by right clicking and clicking close pane
  3. On the bottom right click on the [0-9]+ files

Expected behavior:
[What did you expect to happen?]
Opens the git panel

Actual behavior:
[What actually happened instead?]
Nothing happens or it seems that way, but actually the git panel gets added to the dock on the right but it's closed.

Reproduces how often:
[What percentage of the time does this happen?]
100%

Versions

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Atom    : 1.19.0-dev-58313f6ab
Electron: 1.6.9
Chrome  : 56.0.2924.87
Node    : 7.4.0

Additional Information

gif:

pane

Please include any additional information, configuration or data that might be necessary to reproduce the issue. Screenshots, if appropriate, are helpful as well.

If your issue involves a repository, and that repository is public, please include a link to it.

I noticed this while testing fix for #872
/cc @smashwilson

Activity

  1. self-assigned this
    on May 31, 2017
  2. smashwilson commented on May 31, 2017

    @smashwilson
    Contributor

    This is weird: I can reproduce, but it shows fine on the second click?

  3. smashwilson commented on Jun 1, 2017

    @smashwilson
    Contributor

    Okay, I think I got it 😄 It's published in 0.3.1 and included in Atom master and beta. Care to give it another spin?

  4. ungb commented on Jun 1, 2017

    @ungb
    Author

    LGTM! Awesome job on this @smashwilson a lot smoother experience now that it only takes 1 click instead of two to open the git/github panel :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions