This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Allow for caching of Username and PW with GitHub Package #861
Description
Each time you go to interact with a GitHub repository through Atom, you are required to enter Username and PW. For those using a token due to 2FA, this is painful. Please allow for caching/saving user login information.
Metadata
Metadata
Assignees
Labels
No labels
Activity
smashwilson commentedon May 23, 2017
Do you have a credential helper installed for git?
If not, for the moment that's what we're recommending for credential caching, because Atom will be able to use cached credentials entered at the command line and vice versa. In this case we definitely have a usability problem, though. I've contemplated either implementing a "remember me" checkbox or linking out to that help article from the credential dialog itself as a kind of hint.
If you do, then there's something wrong with the way we interact with the credential helpers! To help us diagnose, can you enable "git diagnostics" in the package settings (via the settings view), trigger a fetch, push, or pull, then expand the appropriate git command in your developer console? That will run git commands with
GIT_TRACE=1and enable a lot of logging that'll be helpful for seeing why it isn't working for you./cc @mauriciord who's reported encountering a similar issue in #436.
jcastle-zz commentedon May 27, 2017
@smashwilson, took me a while to check this out. Been using terminal in the meantime. Have credential helper installed and ran some tests on Atom 1.18 with it. Still didn't change the login process to push files to GitHub. Not a big deal to regenerate the token as PW but still easier to use terminal than to generate on a fresh start. I use terminal for file manipulation so usually have open. Ultimately need a way to store credentials in Atom/Git.
Thanks for you feedback, def a great product, keep it up!
smashwilson commentedon Jun 29, 2017
@jcastle Hmm. Can you try the
PATHworkaround in #436?Bohdan-Khomtchouk commentedon Jul 10, 2017
@smashwilson Hi! Same problem here as @jcastle described above. I tried the
PATHworkaround in #436 but no luck. Really looking forward to aRemember Github credentialsbutton :) Meanwhile, will have to suffer with the username/password copy-pasta at each push/pull.rcrooks commentedon Jul 11, 2017
@Bohdan-Khomtchouk did you also add the command
export PATH=${PATH}:$(git --exec-path)to your ~/.bash_profile file (and reboot)? That finally did it for me, after I'd tried all the other suggestions/steps.jonnylink commentedon Aug 22, 2017
Just to review the issue's history here:
Maybe I'm missing something. How is this helpful @rsese?
Ben3eeE commentedon Aug 22, 2017
@jonnylink #861 (this issue) is not closed.
jonnylink commentedon Aug 22, 2017
My mistake, but it was closed. All three tickets were closed on the same day with a weird circular logic. I'm not trying to pick a fight—I'm just really hoping that this issue will get an honest resolution before being closed again.
My apologies.
winstliu commentedon Aug 22, 2017
@jonnylink Apologies for the confusion. Maybe it would be helpful if you could point out when this issue was previously closed, as it appears to me that this issue hasn't been closed since it was opened.
AGraber commentedon Aug 22, 2017
I join this issue as it's a pain to rewrite credentials over and over.
I hope we can get something here
jonnylink commentedon Aug 22, 2017
@50Wliu ....it wasn't. I'm a dope. Sorry. Got myself confused looking at all the tickets.
winstliu commentedon Aug 22, 2017
No problem - happens sometimes, given the amount of issues :).
Have you tried @smashwilson's suggestions in #861 (comment)?
CmdrNorthpaw commentedon Aug 29, 2017
Why not do a GitHub OAuth process so you wouldn't have to do this stupid authenticating thing over and over and over?
rafaelalvessa commentedon Aug 29, 2017
@OctoPenguin That's fine, and I support your idea, but it wouldn't work with Bitbucket or other services. You need to think of a universal Git solution.
18 remaining items
rsese commentedon Feb 27, 2018
@BoBBer446 your comment was deleted as a violation of the Atom Code of Conduct as it was insulting or derogatory. You may consider this an official warning.
BoBBer446 commentedon Feb 27, 2018
It is of course easy to decide for yourself what should be censored / deleted instead of leaving it to the public. I didn't use swearwords or insult anyone. It's a real pity such a childish attitude here.
rdnt commentedon Feb 27, 2018
This issue is here in order to keep track of a problem and help resolving it. Spamming our mailboxes with what seems to be a meaningless fight does not help the cause at all.
The developers of Atom are coding for the community and they don't get paid for their efforts, so let them do what they do best, contributing to an open source project. Being impatient does not help you or the community.
Thanks for understanding.
brunotdantas commentedon Mar 1, 2018
Hello Guys, the solution I did was pretty much the same as @andrewhharmon.
This worked just fine for me 👍
andrewhharmon commentedon Mar 1, 2018
ooh, you got me there. Not familiar with how Ubuntu stores these creds
sguergachi commentedon Mar 1, 2018
I'm having this issue on Windows and it's very frustrating, since it worked perfectly not long ago.
Every time I try fetching, pulling, or pushing using the atom github package I have to put in my credentials.
I don't use 2FA, I followed @brunotdantas instructions (all github/atom related credentials filled + CMD command) and I still have the same issue.
andrewhharmon commentedon Mar 1, 2018
did you see my post above? I had to delete (not edit) the credentials for it to work.
sguergachi commentedon Mar 1, 2018
@andrewhharmon That worked! Thanks!
smashwilson commentedon Mar 6, 2018
#1327 adds a "remember" checkbox to the credential handler dialog. Check it and your credentials will be stored and retrieved from your OS keychain, which should alleviate this pain considerably 🗝️
The credential helper still takes pains to use git's configured credential helpers if you have any installed, and you may wish to use one regardless. Credentials you store there will be used from both Atom and the command line (or other git tooling!), but credentials you save in Atom will only be used in Atom.
As an added enhancement, if you've logged in to the GitHub panel, that token will be used to auth. I wasn't sure if it had enough permissions but it seems so 🎉
andrewhharmon commentedon Mar 6, 2018
Cool, Thanks
schollii commentedon Apr 10, 2018
For me what worked is turning on credential caching in git, and setting the timeout (which is in seconds) to a high value:
The above means that if I don't commit for more than 11.5 days, I will have to re-enter the password; I can live with that :)
Caching has the advantage that password is not stored in a file, only in memory.