This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
PR labels unreadable in dark themes #772
Description
Description
The labels associated with a PR use the UI theme's text, but the background color from GitHub, leading to conflicts that can make them illegible.
Steps to Reproduce
- Have a branch checked out with an associated PR that has a label
- Attempt to read the label(s) of the PR
Expected behavior:
Labels are legible.
Actual behavior:
Since the labels use the theme color for text, if the theme uses a light color and the label has a light background it becomes near unreadable.
Atom Material (v2):
One Dark:
One Light: (as a usable example)
The label on github.com:
Reproduces how often:
100% of the time.
Versions
Windows 10 x64
Build from atom/atom@4cbff30.
Atom : 1.18.0-dev-4cbff3044 x64
Electron: 1.3.15
Chrome : 52.0.2743.82
Node : 6.5.0
github@0.0.2 (bundled in the build)
Additional Information
The PR/Branch in question was AtomLinter/linter-phpcs#261.
Activity
simurai commentedon May 12, 2017
On .com, the text color gets generated based on what background color a label has:
But it seems the API only provides the background color. So unless the API can be extended to also provide the text color, we would have to use some contrast function. Maybe TinyColor's mostreadable:
☝️ should automatically pick either black or white.
DrianHillman commentedon Jul 2, 2017
Hi! 👋🏽
I'm new to contributing to this project (but not new to Atom); this looks like a great starting point. I'd be happy to submit an implementation for this!
BinaryMuse commentedon Jul 2, 2017
@DrianHillman That sounds great! Feel free ^__^
winstliu commentedon Jul 18, 2017
Fixed by #1000.