Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Testing Authentication #624

Closed
Closed
Testing Authentication#624

Description

@ungb
ungb
opened on Mar 29, 2017

Versions

Atom Version (atom --version):
Atom : 1.17.0-dev-9d5d09f
Electron: 1.3.14
Chrome : 52.0.2743.82
Node : 6.5.0

GitHub Package Version (git --git-dir ~/.atom/packages/github/.git rev-parse head):
9575df3

Activity

  1. ungb commented on Mar 29, 2017

    @ungb
    ungb
    on Mar 29, 2017
    Author

    Findings on Mac (/cc @smashwilson)

    Test HTTPS (Public Repo)

    Test Steps:

    1. Create a public repo on github.com and clone it onto your machines using the https url
    2. cd to <new public repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Mac
        • Fetch
          • Expected: Works
          • Actual: Works
        • Push
          • Expected: Ask for Credential and have option to save.
            ❓ - Actual:Ask for Credential, but doesn't have option to save.
        • Pull
          • Expected: Works
          • Actual: Works

    Test HTTPS (Private Repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the https url
    2. cd to <new private repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
    • Mac
      • Fetch
        • Expected: Ask for credentials
        • Actual: Ask for credentials
      • Push
        • Expected: Ask for Credentials
        • Actual: Ask for Credentials
      • Pull
        • Expected: Ask for credentials?
          ❌ - Actual: git: 'credential-osxkeychain' is not a git command. See 'git --help'. fatal: could not read Username for 'https://github.com': terminal prompts disabled
          image

    Error Message:

    12:55:20.300656 git.c:371               trace: built-in: git 'pull' 'origin' 'master'
12:55:20.302259 run-command.c:350       trace: run_command: 'fetch' '--update-head-ok' 'origin' 'master'
12:55:20.302918 exec_cmd.c:116          trace: exec: 'git' 'fetch' '--update-head-ok' 'origin' 'master'
12:55:20.310218 git.c:371               trace: built-in: git 'fetch' '--update-head-ok' 'origin' 'master'
12:55:20.314189 run-command.c:350       trace: run_command: 'git-remote-https' 'origin' 'https://github.com/ungb/private-repo.git'
12:55:20.660529 run-command.c:350       trace: run_command: 'git credential-osxkeychain get'
12:55:20.663517 run-command.c:209       trace: exec: '/bin/sh' '-c' 'git credential-osxkeychain get' 'git credential-osxkeychain get'
12:55:20.671129 git.c:600               trace: exec: 'git-credential-osxkeychain' 'get'
12:55:20.671581 run-command.c:350       trace: run_command: 'git-credential-osxkeychain' 'get'
git: 'credential-osxkeychain' is not a git command. See 'git --help'.
fatal: could not read Username for 'https://github.com': terminal prompts disabled

    Debug Info:

    git-shell-out-strategy.js:186 git:git config atomGithub.historySha in /Users/bungdonuts/repotest/https/private-repo
git-shell-out-strategy.js:186 git:git config branch.master.remote in /Users/bungdonuts/repotest/https/private-repo
git-shell-out-strategy.js:186 git:git -c gpg.program=/Users/bungdonuts/github/packages/github/bin/gpg-no-tty.sh pull origin master in /Users/bungdonuts/repotest/https/private-repo
git-shell-out-strategy.js:186 git:git config atomGithub.historySha in /Users/bungdonuts/repotest/https/private-repo

    Test SSH Without Password (Public Repo)

    Test Steps:

    1. Create a public repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new public repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Mac
        • Fetch
          • Expected: Works
          • Actual: Works
        • Push
          • Expected: Works
          • Actual:Works
        • Pull
          • Expected: Works
          • Actual: Works

    Test SSH Without Password (Private Repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new private repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Mac
        • Fetch
          • Expected: Works
          • Actual: Works
        • Push
          • Expected: Works
          • Actual: Works
        • Pull
          • Expected: Works
          • Actual: Works

    Test SSH with Password(Public repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new public repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Mac
        • Fetch
          • Expected: Ask for Credential and have option to save.
          • Actual: Ask for Credential, but doesn't have option to save.
        • Push
          • Expected: Ask for Credential and have option to save.
          • Actual: Ask for Credential, but doesn't have option to save.
        • Pull
          • Expected: Ask for Credential and have option to save.
            ❌ - Actual: Doesn't work at all
            image

    Error Message:

    12:57:38.136260 git.c:371               trace: built-in: git 'pull' 'origin' 'master'
12:57:38.137904 run-command.c:350       trace: run_command: 'fetch' '--update-head-ok' 'origin' 'master'
12:57:38.138738 exec_cmd.c:116          trace: exec: 'git' 'fetch' '--update-head-ok' 'origin' 'master'
12:57:38.142182 git.c:371               trace: built-in: git 'fetch' '--update-head-ok' 'origin' 'master'
12:57:38.143797 run-command.c:350       trace: run_command: 'ssh' 'git@github.com' 'git-upload-pack '\''ungb/public-repo.git'\'''
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

    Debug Info:

    git:git config atomGithub.historySha in /Users/bungdonuts/repotest/ssh/public-repo
git-shell-out-strategy.js:186 git:git config branch.master.remote in /Users/bungdonuts/repotest/ssh/public-repo
git-shell-out-strategy.js:186 git:git -c gpg.program=/Users/bungdonuts/github/packages/github/bin/gpg-no-tty.sh pull origin master in /Users/bungdonuts/repotest/ssh/public-repo

    Test SSH with Password(Private repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new private repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Mac
        • Fetch
          • Expected: Ask for Credential and have option to save.
          • Actual: Ask for Credential, but doesn't have option to save.
        • Push
          • Expected: Ask for Credential and have option to save.
          • Actual: Ask for Credential, but doesn't have option to save.
        • Pull
          • Expected: Works
            ❌ - Actual: Doesn't Works
            image

    Error Message:

    12:57:38.136260 git.c:371               trace: built-in: git 'pull' 'origin' 'master'
12:57:38.137904 run-command.c:350       trace: run_command: 'fetch' '--update-head-ok' 'origin' 'master'
12:57:38.138738 exec_cmd.c:116          trace: exec: 'git' 'fetch' '--update-head-ok' 'origin' 'master'
12:57:38.142182 git.c:371               trace: built-in: git 'fetch' '--update-head-ok' 'origin' 'master'
12:57:38.143797 run-command.c:350       trace: run_command: 'ssh' 'git@github.com' 'git-upload-pack '\''ungb/public-repo.git'\'''
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

    Debug info:

    git-shell-out-strategy.js:186 git:git config atomGithub.historySha in /Users/bungdonuts/repotest/ssh/private-repo
git-shell-out-strategy.js:186 git:git config branch.master.remote in /Users/bungdonuts/repotest/ssh/private-repo
git-shell-out-strategy.js:186

    The ❌ were the cases that fail. One thing, I'm not sure if there's a separate issue on or not, is for https, is there a way where we can have a option to save the user/pw? I find it annoying for every action I have to type in my info.

  2. smashwilson commented on Mar 29, 2017

    @smashwilson
    smashwilson
    on Mar 29, 2017
    Contributor

    One thing, I'm not sure if there's a separate issue on or not, is for https, is there a way where we can have a option to save the user/pw? I find it annoying for every action I have to type in my info.

    I punted on that for now (see #597 (comment)). One consideration is that that's actually exactly what installing the git-credential-osxkeychain helper does; it never prompts, all it does it remember your password in your OS keychain the first time you request it.

    One alternative I thought of is to link users to the caching page on GitHub help from the dialog, rather than re-implementing it ourselves? After all, if we cache from Atom the cached password would only be used when using git through Atom, while caching offered by the native credential helpers will be used by all git operations.

  3. ungb commented on Mar 29, 2017

    @ungb
    ungb
    on Mar 29, 2017
    Author

    One alternative I thought of is to link users to the caching page on GitHub help from the dialog, rather than re-implementing it ourselves? After all, if we cache from Atom the cached password would only be used when using git through Atom, while caching offered by the native credential helpers will be used by all git operations.

    I didn't know about this, I'll try this out later.

  4. ungb commented on Mar 30, 2017

    @ungb
    ungb
    on Mar 30, 2017
    Author

    Findings on Windows (didn't see any issues 👍 )

    Even for HTTPS, not sure if my username and pw is stored somewhere because it doesn't ask me for anything, just works

    Test HTTPS (Public Repo)

    Test Steps:

    1. Create a public repo on github.com and clone it onto your machines using the https url
    2. cd to <new public repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Windows
        • Fetch
          • Expected: Works
          • Actual: Works
        • Push
          • Expected: Ask for credentials
          • Actual: Just Works
        • Pull
          • Expected: Works
          • Actual: Works

    Test HTTPS (Private Repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the https url
    2. cd to <new private repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
    • Windows
      • Fetch
        • Expected: Ask for credentials
        • Actual: Works
      • Push
        • Expected:Ask for credentials
        • Actual:Works
      • Pull
        • Expected: Ask for credentials
        • Actual: Works

    Test SSH Without Password (Public Repo)

    Test Steps:

    1. Create a public repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new public repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Windows
        • Fetch
          • Expected: Works
          • Actual: Works
        • Push
          • Expected: Works
          • Actual: Works
        • Pull
          • Expected: Works
          • Actual: Works

    Test SSH Without Password (Private Repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new private repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Windows
        • Fetch
          • Expected: Works
          • Actual: Works
        • Push
          • Expected: Works
          • Actual: Works
        • Pull
          • Expected: Works
          • Actual: Works

    Test SSH with Password(Public repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new public repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Windows
        • Fetch
          • Expected: Ask for Credential and have option to save.
          • Actual: Ask for Credential
        • Push
          • Expected: Ask for Credential and have option to save.
          • Actual: Ask for Credential
        • Pull
          • Expected: Ask for Credential and have option to save.
          • Actual: Ask for Credential

    Test SSH with Password(Private repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new private repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Windows
        • Fetch
          • Expected: Ask for Credential and have option to save.
          • Actual: Ask for Credential
        • Push
          • Expected: Ask for Credential and have option to save.
          • Actual: Ask for Credential
        • Pull
          • Expected: Works
          • Actual: Ask for Credential

  5. smashwilson commented on Mar 30, 2017

    @smashwilson
    smashwilson
    on Mar 30, 2017
    Contributor

    @ungb You can verify git's credential setup by running:

    git config --get-all credential.helper

# Windows
$env:SSH_ASKPASS
$env:GIT_ASKPASS
git config core.askPass

    Depending on the way that you installed git, you likely have at least one credential handler configured in your system gitconfig that saves credentials in your OS keychain (git config --system --edit to see that file). I know my Git for Windows install included one (that even handled 2FA!)

    On MacOS, I believe homebrew-installed git includes the OSX credential helper (which never prompts, it only stores and retrieves from the keychain), but the built-in git does not.

  6. ungb commented on Mar 30, 2017

    @ungb
    ungb
    on Mar 30, 2017
    Author

    on windows:

    image

    On mac:

    image

  7. ungb commented on Mar 30, 2017

    @ungb
    ungb
    on Mar 30, 2017
    Author

    Findings on Ubuntu(didn't see any issues) Saw issues on centos which leads me to believe I need to test on multiple linux platforms

    Looks like ssh with pw uses to unlock and gives you the option to never ask again.

    Test HTTPS (Public Repo)

    Test Steps:

    1. Create a public repo on github.com and clone it onto your machines using the https url
    2. cd to <new public repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Linux
        • Fetch
          • Expected: Works
          • Actual: Works
        • Push
          • Expected: Ask for Credential and have option to save.
          • Actual: Works
        • Pull
          • Expected: Works
          • Actual: Works

    Test HTTPS (Private Repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the https url
    2. cd to <new private repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
    • Linux
      • Fetch
        • Expected: Ask for credentials
        • Actual: Ask for credentials
      • Push
        • Expected:Ask for credentials
        • Actual:Ask for credentials
      • Pull
        • Expected: Ask for credentials
        • Actual:Ask for credentials

    Test SSH Without Password (Public Repo)

    Test Steps:

    1. Create a public repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new public repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Linux
        • Fetch
          • Expected: Works
          • Actual:Works
        • Push
          • Expected: Works
          • Actual:Works
        • Pull
          • Expected: Works
          • Actual:Works

    Test SSH Without Password (Private Repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new private repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Linux
        • Fetch
          • Expected: Works
          • Actual:Works
        • Push
          • Expected: Works
          • Actual:Works
        • Pull
          • Expected: Works
          • Actual:Works

    Expected Result:

    Test SSH with Password(Public repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new public repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Linux
        • Fetch
          • Expected: Ask for Credential and have option to save.
          • Actual:Works
        • Push
          • Expected: Ask for Credential and have option to save.
          • Actual:Works
        • Pull
          • Expected: Ask for Credential and have option to save.
          • Actual:Works

    Test SSH with Password(Private repo)

    Test Steps:

    1. Create a private repo on github.com and clone it onto your machines using the SSH url
    2. cd to <new private repo> and run atom .
    3. On the bottom right try the following actions after clicking on the arrows:
      • Linux
        • Fetch
          • Expected: Works
          • Actual: Works
        • Push
          • Expected:Works
          • Actual: Works
        • Pull
          • Expected: Works
          • Actual:Works

  8. smashwilson commented on Mar 31, 2017

    @smashwilson
    smashwilson
    on Mar 31, 2017
    Contributor

    @ungb btw, #626 should have fixed the issues you were seeing with pull on macOS (and it's why pull is working on other OSes now 😉)

  9. ungb commented on Apr 4, 2017

    @ungb
    ungb
    on Apr 4, 2017
    Author

    I can validate this works on Mac, windows, Linux! Woot! Closing.

  10. ungb
    closed this as completedon Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions