Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Init view shown when reloading #608

Closed

Description

@simurai

When reloading Atom while the GitHub panel is open, it shows the lib/views/git-tab-view.js for a second before switching to the commit view.

flash

Probably doesn't need a loader since that makes it look slow, but hiding the init view should feel smoother.

Versions

Atom Version (atom --version):

Atom    : 1.16.0-dev-6f9a536
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0

GitHub Package Version (git --git-dir ~/.atom/packages/github/.git rev-parse head): 6c0565f

Activity

  1. added this to the Public Release milestone on Mar 29, 2017
  2. smashwilson commented on Mar 30, 2017

    @smashwilson
    Contributor

    This'll be addressed by #586 once I get back to that 😁

  3. smashwilson commented on Apr 20, 2017

    @smashwilson
    Contributor

    Fixed in #633. 🚀

    Interestingly enough, the package doesn't see projects loaded from the command line on activation, although it does see projects loaded from serialized state. As a workaround I'm using the contents of atom.getLoadSettings() to guess whether or not we expect to see a single project and default to either the "loading" view or the "absent" view accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions