This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Can't undo after discarding all hunks in a patch #606
Description
After discarding all hunks in a patch, the patch view is closed and there's no way to undo the discard. Perhaps the undo history for the staged file list should include a discard operation from the patch view if that discard operation removes the last hunk and causes it to close.
Versions
GitHub Package Version (git --git-dir ~/.atom/packages/github/.git rev-parse head):
cdf3b27
Activity
kuychaco commentedon Mar 13, 2017
Yeah thought about this and I'm thinking that a decent UX could be to keep the diff view open in an empty state and display a button in the middle of the pane that takes the user to the staged diff view. How does that sound?
Chatted with @simurai a bit about this before I believe. What're your 💭 s @simurai?
simurai commentedon Mar 14, 2017
👍
"keep the diff view open" is also nice if you wanna do other stuff in the Git panel after discarding. Currently if you discard all hunks, the pane closes and your focus gets move back to the editor. But you might are not done yet and want to commit or select another file.
nathansobo commentedon Mar 14, 2017
👍 for keeping it open.