This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Undo Discard is broken #588
Description
Versions
Atom Version (atom --version):
Atom : 1.14.4
Electron: 1.3.13
Chrome : 52.0.2743.82
Node : 6.5.0
GitHub Package Version (git --git-dir ~/.atom/packages/github/.git rev-parse head):
bf64767
Repro Steps:
- Open a Package in a git repo that has folders, Open a file that is in a sub directory.
- Make some changes to the file in step 1
- discard a few changes you made
- Click on undo discard
Expected: undo discard
Actual: error in console log
root-controller.js:468 Error: ENOENT: no such file or directory, open '/var/folders/lp/h7g12x7j68s02jr25ybpt2vc0000gn/T/github-discard-history-w22r0I/atom/github-package-acceptance.md-before-discard'
at Error (native)(anonymous function) @ root-controller.js:468step @ root-controller.js:25(anonymous function) @ root-controller.js:25
screenshot:
/cc @kuychaco
Metadata
Metadata
Assignees
Labels
No labels
Activity
BinaryMuse commentedon Mar 2, 2017
@ungb Was the file you discarded/undid the discard in in a subdirectory in the repo?
ungb commentedon Mar 2, 2017
yes it was!
BinaryMuse commentedon Mar 2, 2017
In that case it's a dup of #566 (edit: closed that issue as this one has more details)
Fix bug undoing discard for file in subdirectory (fixes #588)
VityaSchel commentedon Mar 28, 2021
I just lost dozens of hours because undo discard doesn't work. Guess next time I will commit and push every line of code I wrote.